Skip to content

Fix issues in inventory-metadata test - #415

Merged
drammock merged 2 commits into
phoible:masterfrom
varunghat:fix/inventory-test-issues
Sep 24, 2026
Merged

drammock merged 2 commits into
phoible:masterfrom
varunghat:fix/inventory-test-issues

Conversation

@varunghat

Copy link
Copy Markdown
Contributor

Two tests were failing in test-inventory-metadata.R, diagnosed it and fixed two bugs

  • Removed mwd from the ISOcode exceptions in the test. "mwd" code is no longer present in our data, so having this exception is unnecessary
  • Changed the phoible-glottolog isocode expect function to use mismatch_indices, fixing a false negative that comes up with checking mismatch alone

@github-actions

Copy link
Copy Markdown

phonemes:
Phonemes: .
Features: ..1

══ Failed ══════════════════════════════════════════════════════════════════════
── 1. Failure ('test-phonemes.R:140:5'): within inventories, phonemes have disti
PHONEMES WITH INDISTINCT FEATURE VECTORS:

A tibble: 50 × 2

Phonemes InventoryIDs

1 b̤̥ pʰ 17
2 d̤̥ tʰ 17
3 ɡ̤̥ kʰ 17
4 ə ɜ 130 224 560 576 1306 1374 1375 1412 1444 1956 1970 2213 2585
5 ɐ̆ ɐ̹̆ 428
6 kǀ͓ kǀ͓x 432
7 kǂ͓ˡ kǂ͓ˡx 432
8 ŋ̥ǃˠˀ ŋ̥ǃˀ 432
9 ɲc ɲcʲ 905
10 d̪ d̻ 998
11 n n̺ 1004
12 s s̺ 1004 1564 2278
13 b̰ p̰ 1020 1783
14 d̪z̪ d̻z̻ 1046
15 s̪ s̻ 1046
16 t̪s̪ t̻s̻ 1046
17 z̪ z̻ 1046
18 ə̃ ɜ̃ 1306
19 d̠ʒʰ t̠ʃʰ 1383
20 əː ɜː 1444
21 z z̺ 1564 2278
22 a ä 1730 2609
23 ë ë̞ 1730 1796
24 ö ö̞ 1730
25 c̤ ɟ̤ 1749 1786
26 i̯œ i̯œ̞ 2167
27 b̥ː pː 2260
28 d̥z̥ ts 2260
29 d̥z̥ʲ tsʲ 2260
30 d̥ʑ̥ tɕ 2260 2287
31 d̥ː tː 2260
32 ɡ̊ː kː 2260
33 ɯ ɯ̝ 2267
34 b̥ p 2272 2283 2287 2324 2351 2389 2408 2424 2432 2476 2509 2579 2590 26…
35 d̥ t 2272 2287
36 f v̥ 2272
37 ɡ̊ k 2272 2283 2287 2296 2324 2351 2389 2408 2424 2432 2476 2509 2590 26…
38 s z̥ 2272
39 ɣ̊ x 2272
40 ʃ ʒ̊ 2272
41 eu̯ e̞u̯ 2278
42 oi̯ o̞i̯ 2278
43 d̺̥ t̺ 2283 2324 2351 2389 2408 2424 2432 2476 2509 2590 2626
44 ɡ̊ʷ kʷ 2283 2324 2351 2389 2408 2424 2476 2509 2590 2626
45 e̞ ɛ̝ 2287
46 s̺̠ ʃ 2308
47 d̥ʒ̥ t̠ʃ 2324 2351 2389 2408 2424 2432 2626
48 d̺̥z̺̥ t̺s̺ 2324 2389 2408 2424 2432 2476 2590
49 d̪̥ t̪ 2579
50 aː äː 2599

══ DONE ════════════════════════════════════════════════════════════════════════

@drammock
drammock merged commit 5dbf266 into phoible:master Sep 24, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants