Repository navigation
refactor(cli): move --public-url to the server flags - #1756
Merged
Merged
Conversation
The public base URL describes the wiki itself, not the mail transport. Later SEO PRs (GitHub #1292) use it for canonical links and the sitemap, so it now lives in serverOptions and is listed under Server in --help. Behaviour is unchanged: with --smtp-host set it is still required and validated the same way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the SEO series for #1292 (after #1732 and #1733).
Moves
--public-url/LEAFWIKI_PUBLIC_URLfrom the Email flags to the Server flags. Later PRs in the series use it as the only source for canonical links and absolute sitemap URLs. Request headers such asX-Forwarded-Hostare never used for those.No behaviour change: with
--smtp-hostset,--public-urlis still required and validated the same way, with the same error messages. Nothing else reads it yet.cmd/leafwiki: the field and flag move fromemailOptionstoserverOptions.--helplists it under "Server".TestRootCommand_PublicURLResolvesIntoServerOptions: the flag and the env var, both trimmed, land in the server options..env.example: the entry moves next to base path, and the description says it is the wiki's public base URL.Checks:
make test,make lint,make verify,make crossgreen.🤖 Generated with Claude Code