Repository navigation
chore: simplify set-version and package scripts - #467
Merged
Merged
Conversation
- Set the version in `package.json` and `package-lock.json` with `npm version --no-git-tag-version` in `set-version`, instead of writing `package.json` and running `npm install` - Run `npm ci` at the start of `npm run package`, so the release zip is built from the dependencies in the lockfile - Document the install step of `npm run package` in the README Signed-off-by: penge <ppenge@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplifies the
set-versionandpackagescripts.Changes
package.jsonandpackage-lock.jsonwithnpm version --no-git-tag-versioninset-version(added in chore: add set-version script #445), instead of writingpackage.jsonand runningnpm installnpm ciat the start ofnpm run package(added in chore: add package script #466), so the release zip is built from the dependencies in the lockfilenpm run packagein the README