Repository navigation
feat: notifications for new tracks - #5
Merged
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
4 tasks
yk-sgr
force-pushed
the
feat/macos-calm
branch
from
October 15, 2026 14:02
99c1b9e to
0553be5
Compare
yk-sgr
force-pushed
the
feat/track-notifications
branch
from
October 15, 2026 14:02
0d7293f to
ffa05c0
Compare
While cloofy's window is in the background, each new track shows a desktop notification with its title, artists and album. The terminal posts it, so cloofy needs no notification permission or app bundle of its own, and a click leads back to the right window. This works the same on Linux. - kitty gets OSC 99: title and body, base64 encoded, and each new track replaces the last notification. Ghostty and WezTerm get OSC 777. iTerm2 gets OSC 9 as a single line. Other terminals get nothing. - Inside tmux the sequence is wrapped for passthrough, which tmux sends on with `allow-passthrough on`. - cloofy turns on focus reporting to know when it is in the background, and stays quiet where the terminal doesn't report focus. - Only cloofy's own playback, only after a track played for 1.5 s, so skipping through doesn't flood. A track that started while cloofy was in front isn't announced later. - `notifications = false` in config.toml turns them off. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
yk-sgr
force-pushed
the
feat/macos-calm
branch
from
October 15, 2026 14:47
0553be5 to
782b840
Compare
yk-sgr
force-pushed
the
feat/track-notifications
branch
from
October 15, 2026 14:47
ffa05c0 to
97380b7
Compare
Owner
|
Merged through #7, unchanged. Fixed on top:
🤖 Generated with Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #4.
This one works at the terminal level, so it's shared code: it works the same on Linux.
What changes
While cloofy's window is in the background, each new track shows a desktop notification with its title, artists and album. The terminal posts it, so:
o=unfocused. A fixedi=cloofymakes each new track replace the last notification (kitty 0.36+).notify;title;bodyKITTY_WINDOW_ID,GHOSTTY_RESOURCES_DIR,WEZTERM_PANE,ITERM_SESSION_ID), so it still works inside tmux, whereTERM_PROGRAMistmux.set -g allow-passthrough on.EnableFocusChange) and stays quiet where the terminal doesn't report focus.notifications = falseinconfig.tomlturns them off.Verified
To test by hand
notifications = false: nothing shows🤖 Generated with Claude Code