Repository navigation
feat(macos): follow the system's audio output - #2
Merged
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
yk-sgr
force-pushed
the
feat/macos-follow-output
branch
from
October 15, 2026 13:15
7872b54 to
629ad77
Compare
3 tasks
Playback moves to AirPods or headphones as they connect, and pauses when the output in use disconnects, instead of carrying on through the speakers. librespot's rodio output stays on the device that was the default when it opened. When that device disconnected, its write loop waited forever for a stream that never drained again, and playback stalled. - cloofy-os reports changes of the default output, through a CoreAudio property listener on macOS. - cloofy-player gets a macOS output that reopens on the new default when it changes. If the output it played on is gone, it reports it and plays silence until the pause arrives, so nothing leaks through the speakers. Its waits are bounded, so a dead stream can't block the player anymore. - The TUI and `cloofy play`/`cloofy connect` pause on the report. The TUI says which output went away. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
yk-sgr
force-pushed
the
feat/macos-now-playing
branch
from
October 15, 2026 14:47
af403da to
2fe8d99
Compare
yk-sgr
force-pushed
the
feat/macos-follow-output
branch
from
October 15, 2026 14:47
629ad77 to
015e57f
Compare
Owner
|
Merged through #7, unchanged. The review found two things, fixed on top:
🤖 Generated with Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #1.
What changes
Paused: AirPods Pro disconnected).How
cloofy-os::audio::OutputWatchis an OS-neutral watcher for "the default output changed". On macOS it's a CoreAudio property listener; elsewhere it'sNone, since PulseAudio follows the default output by itself.cloofy-playergets a macOS output that reopens on the new default when it changes:Engine::newalso returns the receiver for these reports. The TUI,cloofy playandcloofy connectpause on them.Verified
audio output: MacBook Pro-Lautsprecherfrom the new output at startup.To test by hand
🤖 Generated with Claude Code