Repository navigation
Standard view: start the gray marker box at the marker - #57
Open
Sebastian-ubs wants to merge 1 commit into
Open
Sebastian-ubs wants to merge 1 commit into
Sebastian-ubs wants to merge 1 commit into
Conversation
The read-only gray box Standard view draws around content the editor does not edit directly (\fig, sidebars, \periph, ...) inherited its paragraph's first-line text-indent, which a block box applies to its own first line. Inside a \q paragraph (text-indent: -10vw) the opening \fig glyph was drawn past the box's left edge; inside an indented paragraph such as \p it started after an extra gap. Reset text-indent on the box and pin it in the stylesheet test. paranext-core carries the same fix in its vendored copy: paranext/paranext-core#3035 Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
4 of 8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Paired with paranext/paranext-core#3035, which makes the same fix in paranext-core's vendored copies of this stylesheet and has the before/after screenshots and measurements from the app.
Code Review Summary
Branch: standard-view-gray-box-indent
Base: origin/main
Date: 2026-11-19
Review model: Claude Opus 5.5
Files changed: 3
Overview
In Standard view, the read-only gray box drawn around content the editor does not edit directly (
\fig, sidebars,\periph, …) inherited its paragraph's first-linetext-indent, which a block box applies to its own first line. Under\q(-10vw) the opening\figglyph was drawn past the box's left edge; under\pit started after an extra gap. The branch addstext-indent: 0to.marker-editable .unknown-blockinpackages/platform/src/usj-nodes.css, pins it inusj-nodes.css.test.ts, and adds an Unreleased → Fixed entry toCHANGELOG.md. paranext-core carries the same fix in its vendored copies (paranext/paranext-core#3035).The analysis found no critical or important issues. The minor findings are about the new test's wording and robustness.
API Changes
None. No TypeScript exports changed, so the
extract-apireport is unaffected. The stylesheet is not part ofdist/. No selector or class name was added, renamed or removed; the only effect is how the box's first line is laid out in Standard view.Findings
Critical — Must address before merge
None.
Important — Should address before merge
None.
Minor — Consider
/\.marker-editable \.unknown-block\s*\{[^}]*text-indent: 0;/fails ontext-indent:0;or0px. The empty-verse block in the same file collapses whitespace first. Suggested: match the whitespace-collapsed sheet, or loosen totext-indent:\s*0(px)?\s*;.css/cssWithoutCommentswould remove the duplication; arguably out of scope here.-10vwexample) and point at the rule's comment.Inherited(Checked in the app through paranext-core:text-indent: 0also reaches content nested in the box (sidebar,\periph); check that inner\p/\qkeep their own indents.\pand\qinside an\esbsidebar keep their own first-line and hanging indents, at identical positions with and without the fix. Screenshot in Standard view: start the gray marker box at the marker paranext-core#3035.)The test checks stylesheet text only and can't prove the layout, since jsdom does no layout.(Informational; same limit as every other block in the file. The layout was verified in the app through paranext-core, with measurements in Standard view: start the gray marker box at the marker paranext-core#3035.)No author response: the interview was not run (see Interview Notes).
Template Propagation
Shared Regions Modified
None. Neither changed source file has a
#region shared withmarker. paranext-core's vendored copies are already updated in paranext/paranext-core#3035.Extension Config Changes
None.
Positive Observations
.marker-editable .unknown-blockrule in the file, so it cannot leak into the formatted or markers views, where.unknown-blockstaysdisplay: none.text-indenthas no left/right variant, so the reset behaves the same in right-to-left projects. Theming is untouched; the box still takes its colors from--muted-foreground.text-indentcan't satisfy it, and[^}]*keeps the match inside the rule body. It fails without the fix and passes with it;usj-nodes.css.test.tsandusj-nodes.css.gutter-coverage.test.tspass (19/19).Interview Notes
The author interview was not conducted. The author asked for both reviews to run and the results to be posted without stopping for discussion, so no findings have author responses and no design walkthrough was recorded.
Suggested Review Focus
0px) before merging.AI-assisted — Claude Code (Claude Opus 5.5), CLI session; no session URL available
Summary
In Standard view, the dashed gray box around content the editor does not edit directly (
\fig, sidebars,\periph, …) could start partway into its marker. The box inherited its paragraph's first-linetext-indent, and a block box applies that to its own first line:\qline (text-indent: -10vw), the opening\figglyph was drawn past the box's left edge.\p, the glyph started after an extra gap.paranext-core carries the same one-line fix in its vendored copy of this stylesheet, with before/after screenshots and measurements from the app: paranext/paranext-core#3035.
Changes
.marker-editable .unknown-blocksetstext-indent: 0(packages/platform/src/usj-nodes.css).usj-nodes.css.test.tspins the rule.CHANGELOG.md: entry under Unreleased → Fixed.The stylesheet is not part of
dist/, so there is no rebuiltdist/in this PR.Testing
usj-nodes.css.test.tsandusj-nodes.css.gutter-coverage.test.tspass (19/19).AI-assisted: Claude Code (Claude Opus 5.5) wrote the change and test. Reviewed by the author.
🤖 Generated with Claude Code
This change is