Repository navigation
PT-4763: Report p as the block marker in an implied paragraph - #56
Conversation
irahopkinson
left a comment
There was a problem hiding this comment.
@irahopkinson+AI made 5 comments.
Reviewable status: 0 of 7 files reviewed, 5 unresolved discussions (waiting on katherinejensen00).
a discussion (no related file):
I thought the editor used to do this, but there probably weren't tests, so it could have been changed. Thanks for fixing this.
I reviewed the implied-paragraph blockMarker change and the tests and changelog around it, and have 5 findings, all minor. Each comment shows the severity I settled on; checked and confirmed means the finding was verified against the code, and needs a human call means it could not be settled either way and is yours to judge.
Findings that could not be attached to a line in this diff
#6 (low · checked and confirmed) packages/platform/src/editor/Editor.tsx:1450 - Changing the paragraph style of a selection that runs from the \id line into verses outside any paragraph marker splits the \id line but leaves those verses' paragraph unchanged.
What happens: on the book path, formatPara calls $splitParagraphWithMarker (Editor.tsx:1419), then walks the root siblings after the new paragraph and retags only those where $isParaNode(sibling) holds (Editor.tsx:1450). An ImpliedParaNode fails $isParaNode, so when the selection ends in one, the walk reaches it as isEndBlock (Editor.tsx:1446) and breaks without retagging it.
Why it matters: the behavior predates this PR (Editor.tsx is unchanged), but the \id, \c, bare-verses layout is the one this change makes the paragraph menu usable in. Reaching it takes a drag from the book line across the chapter into the verses; the result is a partial retag, with no text lost.
Fix: At Editor.tsx:1450, change $isParaNode(sibling) to $isSomeParaNode(sibling) (import it from shared next to $isParaNode) so an implied paragraph reached as the end block is retagged too. The \c chapter node must stay excluded, which $isSomeParaNode does. Add a formatPara test in Editor.test.tsx for a selection anchored in the \id line and ending in an implied paragraph, asserting both the split and that the verses end up in a paragraph with the picked marker, and that undo restores the original USJ. Add a ### Fixed entry under ## [Unreleased] in packages/platform/CHANGELOG.md and rebuild dist/ and etc/ with pnpm rebuild-committed-output.
Not attached to a line: this finding is in a file the pull request does not change, so the review has no file to attach a comment to
(AI-assisted, with my guidance)
packages/platform/src/editor/Editor.test.tsx line 2082 at r1 (raw file):
}); // Verses outside any paragraph marker load as an implied paragraph, which reports `p` as its
#4 - low · checked and confirmed
The comment above the new retag test says the reported p is what lets the menu offer the retag, but the test neither reads the reported marker nor goes through a menu.
What happens: the comment at Editor.test.tsx:2082-2083 ties the test to the implied paragraph reporting p as its block marker. The test body places the caret with lexicalEditor.update and calls formatPara("q1") directly, and never passes or reads onStateChange; formatPara (Editor.tsx:1355) is unchanged by this PR, so the test passes on the merge base too.
Why it matters: maintenance only - a reader takes the test as covering the new reporting when it covers only the retag path.
Fix: reword the comment at Editor.test.tsx:2082-2083 to say the test pins that formatPara retags an implied paragraph, a path hosts reach once the block marker is reported, without claiming the test checks the report.
How this was checked: The comment at Editor.test.tsx:2082-2083 (added by this PR) says the implied paragraph "reports p as its block marker, so the paragraph menu offers to retag it". The test body (about 2084-2125) mounts via mountEditorForUndo, places the caret with lexicalEditor.update, calls getEditorRef(ref).formatPara("q1") directly and asserts getUsj() content. It never passes or reads onStateChange and never renders a menu, so it checks only the retag path, which the PR leaves unchanged. The comment therefore attributes coverage of the reporting to a test that does not cover it. Maintenance-only impact.
Other findings in this file: #5
packages/platform/src/editor/Editor.test.tsx line 2084 at r1 (raw file):
// Verses outside any paragraph marker load as an implied paragraph, which reports `p` as its // block marker, so the paragraph menu offers to retag it like any other paragraph. it("retags an implied paragraph into a real paragraph that keeps its verses", async () => {
#5 - low · checked and confirmed
No test checks that the platform <Editor> reports blockMarker: "p" to its host's onStateChange in verses outside any paragraph marker.
What happens: the new reporting is tested only at plugin level, in StateChangePlugin.test.tsx:142-228 through baseTestEnvironment. The one new <Editor>-level test (Editor.test.tsx:2084) exercises formatPara and never passes onStateChange, the prop hosts consume (packages/platform/src/editor/editor.model.ts:1057).
Why it matters: test-only, with no behavior effect today. paraMarkerSelection.test.tsx:214-222 already covers the onStateChange wiring for an explicit paragraph, so the gap is only the implied-paragraph case end to end through <Editor>.
Fix: add an <Editor>-level test in packages/platform/src/editor/ that passes onStateChange, places the caret in an implied paragraph via <EditorRefPlugin editorRef={ref} />, and expects blockMarker: "p", following packages/platform/src/editor/paraMarkerSelection.test.tsx:221.
How this was checked: The new implied-paragraph behavior ($isSomeParaNode in libs/shared-react/src/plugins/usj/StateChangePlugin.tsx) is pinned only by StateChangePlugin.test.tsx. The one new Editor.test.tsx test (about 2084) never passes onStateChange and asserts getUsj() content after formatPara. No Editor-level test asserts blockMarker "p" for an implied paragraph; grep of Editor.test.tsx finds no blockMarker or onStateChange assertion at all. paraMarkerSelection.test.tsx:214-222 covers the onStateChange wiring generically (blockMarker "li2"), and Editor.tsx handleStateChange (about 2012) forwards the snapshot unchanged, so the wiring itself is already covered and the remaining gap is small: only the implied-paragraph case through the full Editor.
Other findings in this file: #4
libs/shared-react/src/plugins/usj/StateChangePlugin.test.tsx line 142 at r1 (raw file):
// character-marker menus by the reported block marker, so an implied paragraph must report one - // the default paragraph marker - or the host stays on whichever block it last heard about. describe("StateChangePlugin in an implied paragraph", () => {
#1 - low · checked and confirmed
Reverting the verse-block lookup at StateChangePlugin.tsx:102 to $isParaNode leaves StateChangePlugin.test.tsx passing, though the block-verse view then reports no block marker for verses outside any paragraph marker.
What happens: in the block-verse layout a verse block can hold an implied paragraph (packages/platform/src/editor/adaptors/verse-block-utils.test.ts:292), and StateChangePlugin.tsx:102 resolves through it with $isSomeParaNode. The four tests under describe("StateChangePlugin in an implied paragraph") (StateChangePlugin.test.tsx:142-228) all place the implied paragraph at the root, never inside $createVerseBlockNode, and the helper $textInBlockPara throws on anything that is not a ParaNode (line 56).
Why it matters: test-only, with no behavior effect today; the source comment says to keep both sites on the same predicate, and no test enforces it. The PR description notes this case as not separately tested, but gives no reason to leave it that way, and the test below is small enough to add here.
Fix: add a test that builds $createVerseBlockNode("1") holding a $createImpliedParaNode() with the block-verse node set and expects blockMarker "p", and widen $textInBlockPara at StateChangePlugin.test.tsx:56 to accept $isSomeParaNode.
How this was checked: In a separate worktree I reverted StateChangePlugin.tsx:102 to $isParaNode (adding the import it needs) and ran StateChangePlugin.test.tsx: all 8 tests passed. The four implied-paragraph tests (StateChangePlugin.test.tsx:142-228) put $createImpliedParaNode() at the root, never inside $createVerseBlockNode, and $textInBlockPara (line 56) throws unless the node is a $isParaNode. I then added the proposed test, a verse block holding an implied paragraph with $textInBlockPara widened to $isSomeParaNode. It fails under the revert (expected undefined to be 'p') and passes on the real code. The gap is test-only, with no behavior effect today.
libs/shared-react/src/plugins/usj/StateChangePlugin.tsx line 114 at r1 (raw file):
if ( elementDOM !== null && ($isSomeParaNode(node) || $isBookNode(node) || $isImmutableChapterNode(node))
#2 - low · checked and confirmed
In verses outside any paragraph marker, Platform.Bible's paragraph-style menu now opens with p pre-highlighted, so pressing Enter on the highlighted entry writes a new \p marker into text that had none.
What happens: ImpliedParaNode.getMarker() returns PARA_MARKER_DEFAULT (libs/shared/src/nodes/usj/ImpliedParaNode.ts:30-32). The guard at StateChangePlugin.tsx:112-116 now accepts $isSomeParaNode(node) and reports blockMarker: node.getMarker(), i.e. p. A host that passes blockMarker as its menu's default highlight (Platform.Bible's paragraph-style-trigger.component.tsx passes defaultHighlightedMarker={blockMarker}) then offers p as the current style; choosing it runs formatPara("p"), which replaces the implied paragraph with an explicit ParaNode \p.
Why it matters: a user who opens the menu and presses Enter without moving the highlight changes the file's USFM without intending to. Reporting p is deliberate and the host owns the highlight choice, so the library's part is only to document what accepting p does.
Fix: Extend the blockMarker TSDoc on StateChangeSnapshot (libs/shared-react/src/plugins/usj/StateChangePlugin.tsx:32-35) to say that the p reported for an implied paragraph is not an explicit marker: a host that offers p as the current style (for example by pre-highlighting it) will, when the user accepts it, run EditorRef.formatPara("p"), which replaces the implied paragraph with an explicit \p paragraph. Keep the TSDoc free of ticket IDs, then run pnpm rebuild-committed-output so packages/platform/dist/index.d.ts and etc/ match the new comment in the same PR.
|
All five addressed in 4061d55..bd09b63. #6 ( #4 (retag test comment): reworded in 4061d55. It now says the test pins that #5 ( #1 (implied paragraph inside a verse block): added as proposed (2a35109). #2 (pre-highlighted I've updated the PR description to match: three predicate sites, not two, and the "not separately tested" note is gone. |
Verses outside any paragraph marker live in an ImpliedParaNode, which StateChangePlugin did not count as a paragraph, so onStateChange never fired there and hosts kept the previous block's marker (often `id`). Hosts scope their character-marker menus by blockMarker, so the menu offered the wrong markers in those verses. Count ImpliedParaNode as a paragraph at both sites (verse-block resolution and the reporting guard) via $isSomeParaNode; it reports the default paragraph marker `p`. Rebuilt packages/platform/dist. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
formatPara on verses outside any paragraph marker wraps them in a real paragraph that keeps its verses, and undo restores the original USJ. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
getViewOptions() returns ViewOptions | undefined, which
mountEditorForUndo's `view: ViewOptions` rejects, so the platform-editor
typecheck failed in CI. Use editorView("standard") from the view test
helpers, which wraps requireViewOptions(STANDARD_VIEW_MODE).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
formatPara's book path splits the \id line, then walks the root siblings up to the block the selection ends in. The walk only retagged ParaNodes, so an implied paragraph at the end of the selection kept no paragraph marker. It now guards with $isSomeParaNode; the \c chapter is still skipped. Also adds an <Editor>-level test that onStateChange reports `p` when the caret moves from the \id line into an implied paragraph, and rewords the existing retag test's comment so it no longer claims to cover reporting. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The block verse layout resolves through the verse block to the paragraph holding the caret, and that lookup must accept an implied paragraph just as the reporting guard does. Nothing pinned it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A host that offers the reported `p` as the current style and lets the
user accept it calls formatPara("p"), which replaces the implied
paragraph with an explicit \p.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
bd09b63 to
17c5416
Compare
irahopkinson
left a comment
There was a problem hiding this comment.
@irahopkinson+AI made 5 comments and resolved 5 discussions.
Reviewable status: 0 of 8 files reviewed, all discussions resolved.
a discussion (no related file):
Previously, irahopkinson+AI (Agent AI for Ira Hopkinson) wrote…
I thought the editor used to do this, but there probably weren't tests, so it could have been changed. Thanks for fixing this.
I reviewed the implied-paragraph
blockMarkerchange and the tests and changelog around it, and have 5 findings, all minor. Each comment shows the severity I settled on;checked and confirmedmeans the finding was verified against the code, andneeds a human callmeans it could not be settled either way and is yours to judge.Findings that could not be attached to a line in this diff
#6 (low · checked and confirmed) packages/platform/src/editor/Editor.tsx:1450 - Changing the paragraph style of a selection that runs from the
\idline into verses outside any paragraph marker splits the\idline but leaves those verses' paragraph unchanged.What happens: on the book path,
formatParacalls$splitParagraphWithMarker(Editor.tsx:1419), then walks the root siblings after the new paragraph and retags only those where$isParaNode(sibling)holds (Editor.tsx:1450). AnImpliedParaNodefails$isParaNode, so when the selection ends in one, the walk reaches it asisEndBlock(Editor.tsx:1446) and breaks without retagging it.Why it matters: the behavior predates this PR (
Editor.tsxis unchanged), but the\id,\c, bare-verses layout is the one this change makes the paragraph menu usable in. Reaching it takes a drag from the book line across the chapter into the verses; the result is a partial retag, with no text lost.Fix: At
Editor.tsx:1450, change$isParaNode(sibling)to$isSomeParaNode(sibling)(import it fromsharednext to$isParaNode) so an implied paragraph reached as the end block is retagged too. The\cchapter node must stay excluded, which$isSomeParaNodedoes. Add aformatParatest inEditor.test.tsxfor a selection anchored in the\idline and ending in an implied paragraph, asserting both the split and that the verses end up in a paragraph with the picked marker, and that undo restores the original USJ. Add a### Fixedentry under## [Unreleased]inpackages/platform/CHANGELOG.mdand rebuilddist/andetc/withpnpm rebuild-committed-output.Not attached to a line: this finding is in a file the pull request does not change, so the review has no file to attach a comment to
(AI-assisted, with my guidance)
Confirmed at 17c5416: the new test fails without the guard change. Thanks.
libs/shared-react/src/plugins/usj/StateChangePlugin.tsx line 114 at r1 (raw file):
Previously, irahopkinson+AI (Agent AI for Ira Hopkinson) wrote…
#2 - low · checked and confirmed
In verses outside any paragraph marker, Platform.Bible's paragraph-style menu now opens with
ppre-highlighted, so pressing Enter on the highlighted entry writes a new\pmarker into text that had none.What happens:
ImpliedParaNode.getMarker()returnsPARA_MARKER_DEFAULT(libs/shared/src/nodes/usj/ImpliedParaNode.ts:30-32). The guard atStateChangePlugin.tsx:112-116now accepts$isSomeParaNode(node)and reportsblockMarker: node.getMarker(), i.e.p. A host that passesblockMarkeras its menu's default highlight (Platform.Bible'sparagraph-style-trigger.component.tsxpassesdefaultHighlightedMarker={blockMarker}) then offerspas the current style; choosing it runsformatPara("p"), which replaces the implied paragraph with an explicitParaNode\p.Why it matters: a user who opens the menu and presses Enter without moving the highlight changes the file's USFM without intending to. Reporting
pis deliberate and the host owns the highlight choice, so the library's part is only to document what acceptingpdoes.Fix: Extend the
blockMarkerTSDoc onStateChangeSnapshot(libs/shared-react/src/plugins/usj/StateChangePlugin.tsx:32-35) to say that thepreported for an implied paragraph is not an explicit marker: a host that offerspas the current style (for example by pre-highlighting it) will, when the user accepts it, runEditorRef.formatPara("p"), which replaces the implied paragraph with an explicit\pparagraph. Keep the TSDoc free of ticket IDs, then runpnpm rebuild-committed-outputsopackages/platform/dist/index.d.tsandetc/match the new comment in the same PR.
Confirmed at 17c5416, thanks.
libs/shared-react/src/plugins/usj/StateChangePlugin.test.tsx line 142 at r1 (raw file):
Previously, irahopkinson+AI (Agent AI for Ira Hopkinson) wrote…
#1 - low · checked and confirmed
Reverting the verse-block lookup at
StateChangePlugin.tsx:102to$isParaNodeleavesStateChangePlugin.test.tsxpassing, though the block-verse view then reports no block marker for verses outside any paragraph marker.What happens: in the block-verse layout a verse block can hold an implied paragraph (
packages/platform/src/editor/adaptors/verse-block-utils.test.ts:292), andStateChangePlugin.tsx:102resolves through it with$isSomeParaNode. The four tests underdescribe("StateChangePlugin in an implied paragraph")(StateChangePlugin.test.tsx:142-228) all place the implied paragraph at the root, never inside$createVerseBlockNode, and the helper$textInBlockParathrows on anything that is not aParaNode(line 56).Why it matters: test-only, with no behavior effect today; the source comment says to keep both sites on the same predicate, and no test enforces it. The PR description notes this case as not separately tested, but gives no reason to leave it that way, and the test below is small enough to add here.
Fix: add a test that builds
$createVerseBlockNode("1")holding a$createImpliedParaNode()with the block-verse node set and expectsblockMarker"p", and widen$textInBlockParaatStateChangePlugin.test.tsx:56to accept$isSomeParaNode.How this was checked: In a separate worktree I reverted StateChangePlugin.tsx:102 to
$isParaNode(adding the import it needs) and ran StateChangePlugin.test.tsx: all 8 tests passed. The four implied-paragraph tests (StateChangePlugin.test.tsx:142-228) put$createImpliedParaNode()at the root, never inside$createVerseBlockNode, and$textInBlockPara(line 56) throws unless the node is a$isParaNode. I then added the proposed test, a verse block holding an implied paragraph with$textInBlockParawidened to$isSomeParaNode. It fails under the revert (expected undefined to be 'p') and passes on the real code. The gap is test-only, with no behavior effect today.
Confirmed at 17c5416, thanks.
packages/platform/src/editor/Editor.test.tsx line 2082 at r1 (raw file):
Previously, irahopkinson+AI (Agent AI for Ira Hopkinson) wrote…
#4 - low · checked and confirmed
The comment above the new retag test says the reported
pis what lets the menu offer the retag, but the test neither reads the reported marker nor goes through a menu.What happens: the comment at
Editor.test.tsx:2082-2083ties the test to the implied paragraph reportingpas its block marker. The test body places the caret withlexicalEditor.updateand callsformatPara("q1")directly, and never passes or readsonStateChange;formatPara(Editor.tsx:1355) is unchanged by this PR, so the test passes on the merge base too.Why it matters: maintenance only - a reader takes the test as covering the new reporting when it covers only the retag path.
Fix: reword the comment at
Editor.test.tsx:2082-2083to say the test pins thatformatPararetags an implied paragraph, a path hosts reach once the block marker is reported, without claiming the test checks the report.How this was checked: The comment at Editor.test.tsx:2082-2083 (added by this PR) says the implied paragraph "reports
pas its block marker, so the paragraph menu offers to retag it". The test body (about 2084-2125) mounts via mountEditorForUndo, places the caret with lexicalEditor.update, calls getEditorRef(ref).formatPara("q1") directly and asserts getUsj() content. It never passes or reads onStateChange and never renders a menu, so it checks only the retag path, which the PR leaves unchanged. The comment therefore attributes coverage of the reporting to a test that does not cover it. Maintenance-only impact.Other findings in this file: #5
Confirmed at 17c5416, thanks.
packages/platform/src/editor/Editor.test.tsx line 2084 at r1 (raw file):
Previously, irahopkinson+AI (Agent AI for Ira Hopkinson) wrote…
#5 - low · checked and confirmed
No test checks that the platform
<Editor>reportsblockMarker: "p"to its host'sonStateChangein verses outside any paragraph marker.What happens: the new reporting is tested only at plugin level, in
StateChangePlugin.test.tsx:142-228throughbaseTestEnvironment. The one new<Editor>-level test (Editor.test.tsx:2084) exercisesformatParaand never passesonStateChange, the prop hosts consume (packages/platform/src/editor/editor.model.ts:1057).Why it matters: test-only, with no behavior effect today.
paraMarkerSelection.test.tsx:214-222already covers theonStateChangewiring for an explicit paragraph, so the gap is only the implied-paragraph case end to end through<Editor>.Fix: add an
<Editor>-level test inpackages/platform/src/editor/that passesonStateChange, places the caret in an implied paragraph via<EditorRefPlugin editorRef={ref} />, and expectsblockMarker: "p", followingpackages/platform/src/editor/paraMarkerSelection.test.tsx:221.How this was checked: The new implied-paragraph behavior ($isSomeParaNode in libs/shared-react/src/plugins/usj/StateChangePlugin.tsx) is pinned only by StateChangePlugin.test.tsx. The one new Editor.test.tsx test (about 2084) never passes onStateChange and asserts getUsj() content after formatPara. No Editor-level test asserts blockMarker "p" for an implied paragraph; grep of Editor.test.tsx finds no blockMarker or onStateChange assertion at all. paraMarkerSelection.test.tsx:214-222 covers the onStateChange wiring generically (blockMarker "li2"), and Editor.tsx handleStateChange (about 2012) forwards the snapshot unchanged, so the wiring itself is already covered and the remaining gap is small: only the implied-paragraph case through the full Editor.
Other findings in this file: #4
Confirmed at 17c5416, thanks.
irahopkinson
left a comment
There was a problem hiding this comment.
@irahopkinson made 1 comment.
Reviewable status: 0 of 8 files reviewed, all discussions resolved (waiting on irahopkinson+AI).
Summary
When the caret is in verses outside any paragraph marker (an implied paragraph),
StateChangePluginemitted no state change. Hosts kept the previous block'sblockMarker, usuallyid. Platform.Bible scopes its character-marker menu byblockMarker, so in those verses the menu offered\id's markers (ior) instead of body-text ones (nd,wj, …).The plugin now counts an implied paragraph as a paragraph and reports
p, whichImpliedParaNode.getMarker()already returns. The fix is a predicate change,$isParaNode→$isSomeParaNode, at three sites: two inStateChangePlugin, and the sibling walk informatPara's\idpath, which reportingpnow makes reachable. The rest of the PR is tests, TSDoc, the changelog, and the rebuiltdist.Jira: PT-4763. The paranext-core half (the character-marker bar follows the caret into these verses) is a separate PR, opened after this merges and is staged into core.
Review guide
libs/shared-react/src/plugins/usj/StateChangePlugin.tsx$isParaNode→$isSomeParaNodeat both the verse-block resolution and the reporting guard, plus TSDoc onStateChangeSnapshot.blockMarker: the reportedpis not in the file, and accepting it as a style writes an explicit\p.libs/shared-react/src/plugins/usj/StateChangePlugin.test.tsxp; replaces a previous block'sid; reports a character marker (nd) ascontextMarker; inside a verse block; empty document.packages/platform/src/editor/Editor.tsxformatPara's\idpath: the walk over root siblings after the split guards with$isSomeParaNode, so a selection from\idthat ends in an implied paragraph retags it. The\cchapter is still skipped.packages/platform/src/editor/Editor.test.tsxformatPara("q1")turns an implied paragraph into a real\q1that keeps its verses, with undo (passes onmaintoo; it pins the retag path).formatParaon a selection from\idinto an implied paragraph retags the verses, with undo.<Editor>withhasExternalUIreportsblockMarkerid, thenp, as the caret moves from\idinto an implied paragraph.packages/platform/CHANGELOG.mdpackages/platform/dist/*pnpm rebuild-committed-output. Skipindex.js/.map: the diff is minifier renaming.index.d.tschanges only the TSDoc.Details
p, notundefinedor a new field. Withundefined, the host's character-marker menu has no parent marker, so it is empty and its button is disabled exactly where the user is typing. AnisImpliedParaflag onStateChangeSnapshotwould grow the public API for one consumer, whenpis already what the node reports.pfor text that has no\p, and a host that pre-highlights it lets one Enter write a new\p. In Platform.Bible that is Power mode only, since Simple mode is structure-protected. The TSDoc says so, and the core PR's ADR records it.Testing
pnpm nx run-many -t lint typecheckpasses for all 9 projects, and so doestest, except two platform files (markerMenuHarness,blockVersePositions) that failed under the full parallel run at about 6× their normal duration and pass when run on their own.StateChangePlugintests fail onmain("expected undefined to be 'p'") and pass here. The verse-block test fails even with only the verse-block lookup reverted.\id-to-implied-paragraphformatParatest fails onmain(the verses keep no paragraph marker). The<Editor>onStateChangetest fails withStateChangePluginreverted.Editor.testretag test goes red if theformatParacall or theundois removed.scripts/verify-committed-dist.mjs: committed build output is current.Editorialfrom this build seesonStateChangereportblockMarker: 'p'in an implied paragraph. It fails against the build currently staged in core.🤖 Generated with Claude Code
This change is