Skip to content

docs(compose-lint): make Node engines comment version-agnostic - #115

Merged
owine merged 1 commit into
mainfrom
docs/compose-lint-node-engines-comment
Nov 5, 2026
Merged

owine merged 1 commit into
mainfrom
docs/compose-lint-node-engines-comment

Conversation

@owine

@owine owine commented Nov 5, 2026 •

Copy link
Copy Markdown
Owner

Follow-up to #114 (Node 24.22.2 → 26.13.0).

The comment above the Set up Node.js for Renovate validator step hard-coded renovate's engines.node range as ^24.11.0. That went stale once renovate@44.220.0 changed it to ^24.11.0 || ^26.13.0 and #114 merged.

  • Describe the rule ("a runtime inside the engines.node range renovate@latest declares") rather than a specific value.
  • Add a note to hold the next LTS-major Renovate PR until renovate@latest engines.node includes it. That's the gating we did manually for chore(deps): update node.js to v26 #114.

Comment-only change; no behavior change.

Summary by Sourcery

Clarify the Renovate validator’s Node.js version guidance without changing workflow behavior.

Enhancements:

  • Make the Compose lint workflow’s Renovate Node.js guidance version-agnostic and document when to advance to the next LTS major.

Documentation:

  • Update the workflow comment to describe Renovate’s declared Node.js engine range and the gating condition for next-major upgrades.

The setup-node comment hard-coded renovate's engines range (^24.11.0),
which went stale when renovate@44.220.0 added ^26.13.0 and #114 moved
NODE_VERSION to 26.13.0. Describe the rule instead of the value, and
note that a new LTS major PR should be held until renovate@latest's
engines.node includes it.
@sourcery-ai

sourcery-ai Bot commented Nov 5, 2026

Copy link
Copy Markdown

Sorry @owine, you've used your own review budget of 250,000 diff characters for the last 7 days.

You can request another review in 1 day and 7 hours by commenting @sourcery-ai review. Upgrade to get a review now.

@sourcery-ai

sourcery-ai Bot commented Nov 5, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the Compose Lint workflow documentation to remain accurate as renovate@latest changes its supported Node engine range, including guidance to gate future LTS-major upgrades; the change is comment-only and does not alter behavior.

File-Level Changes

Change Details Files
Make the workflow comment explain the Renovate Node compatibility rule generically and document the manual gate for future LTS-major upgrades.
  • Replace the hard-coded Node engine range with a description based on renovate@latest's engines.node range.
  • Instruct reviewers to hold the next LTS-major Renovate PR until renovate@latest supports that major.
  • Clarify that the Node version remains exact-pinned and Renovate-managed, with no workflow behavior changes.
.github/workflows/compose-lint.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@owine
owine merged commit 203e605 into main Nov 5, 2026
2 checks passed
@owine
owine deleted the docs/compose-lint-node-engines-comment branch November 5, 2026 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant