Skip to content

Refresh stale Stackwich agents on a Codex upgrade - #52

Merged
ovhirup merged 1 commit into
mainfrom
issue-codex-stale-agents
Nov 2, 2026
Merged

ovhirup merged 1 commit into
mainfrom
issue-codex-stale-agents

Conversation

@ovhirup

@ovhirup ovhirup commented Nov 2, 2026

Copy link
Copy Markdown
Owner

Closes #51.

Problem

This is the Codex-port version of #31. Step 4 of codex/SKILL.md only handled agent names taken by unrelated agents. On an upgrade, advisor.toml, executor.toml and verifier.toml from an earlier revision were left as they were, so the new policy referred to agents that lacked its newer rules.

This came up in a real rev 3 → rev 7 upgrade today. The agents were refreshed only because the request explicitly asked for it.

Change

codex/SKILL.md only. These are installer steps, not the policy block, so stackwich-codex-rev stays at 7.

  • Step 4: an existing agent file whose header comment is the Stackwich Codex credit counts as an earlier install, not a collision.
    • The installer compares it with its template, with any rename applied, and ignores model and model_reasoning_effort, which users may tune.
    • If the file differs, it offers an in-place refresh that keeps the agent's name and model settings. It never overwrites without asking.
    • It makes this offer on every upgrade, even if the user doesn't mention agents.
  • Step 5: a new check that every Stackwich agent written or kept matches its template, or that the user chose to keep an older one.
  • CHANGELOG: a new Unreleased section. The version stays 3.6.1 because nothing changes for Claude Code plugin users; Codex users get the fix by copying codex/ again.

The wording follows the Claude Code skill's step 3 and step 4 check 5 (#31), adapted to TOML files and the comment credit line.

Verification

  • The credit line quoted in step 4 matches the header comment in all three templates in codex/references/templates.md exactly. A script checked this.
  • python3 tools/validate.py: all 9 categories OK. tools/: 63 tests pass. measured/: OK.
  • The release workflow's CHANGELOG parsing still finds exactly one 3.6.1 section with the new Unreleased heading in place, so a later release isn't blocked.

Limits

The installer is carried out by Codex, so no deterministic test can run step 4. Checking that Codex follows it needs the runtime evals parked in #12.


Generated by Claude Code

The Codex installer's step 4 only handled names taken by unrelated
agents, so an upgrade left advisor/executor/verifier from an earlier
revision in place: a real rev 3 -> 7 upgrade refreshed them only because
the request said so explicitly.

- Step 4: an agent carrying the Stackwich Codex credit comment is an
  earlier install. Compare it with its template (renames applied, model
  and model_reasoning_effort ignored); if it differs, offer an in-place
  refresh that keeps its name and model settings, never overwriting
  without asking, and offer it on every upgrade.
- Step 5: check each Stackwich agent written or kept matches its template.
- CHANGELOG: an Unreleased section; no policy or plugin change, so
  stackwich-codex-rev stays 7 and the version stays 3.6.1.

Mirrors #31 for the Claude Code skill.

Closes #51.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01TgCNfwCj3YG9xP3pMB6z2k
@ovhirup ovhirup mentioned this pull request Nov 2, 2026
15 of 16 tasks
@ovhirup
ovhirup marked this pull request as ready for review November 2, 2026 09:29
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-02T09:30:47.532744Z 672b847 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@ovhirup
ovhirup merged commit 269064e into main Nov 2, 2026
2 checks passed
@ovhirup
ovhirup deleted the issue-codex-stale-agents branch November 2, 2026 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Codex installer leaves stale Stackwich agents in place on upgrade

2 participants