Repository navigation
Keep .stackwich/ out of git when the tools create it - #44
Merged
Merged
Conversation
handoff.py and verify_gate.py created .stackwich/ in the user's repository without ignoring it, so a later `git add -A` committed the handoff (plan, next step, git status) and the verification records. The docs only asked users to add it to .gitignore by hand. - verify_gate.state_dir() creates .stackwich/ with a .gitignore of `*`, so the directory ignores itself without touching the user's .gitignore. An existing .stackwich/.gitignore is kept. - handoff.py save and verify_gate.py run both create it through state_dir(). - docs/handoff.md and docs/verify-gate.md say so; a handoff written by hand, without the tools, still needs .stackwich/ ignored (policy wording: #41). Closes #34. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TgCNfwCj3YG9xP3pMB6z2k
This was referenced Nov 2, 2026
ovhirup
marked this pull request as ready for review
November 2, 2026 08:00
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #34.
Problem
tools/handoff.pyandtools/verify_gate.pycreate.stackwich/in the user's repository without ignoring it. A latergit add -Aorgit commit -a, from an executor or a person, then commits the handoff and the verification records. The handoff contains the plan, the next step andgit status. The docs only asked users to add.stackwich/to.gitignoreby hand.Change
verify_gate.state_dir()creates.stackwich/together with a.gitignorecontaining*, so the directory ignores itself. The user's tracked.gitignoreis not touched, and if.stackwich/.gitignorealready exists it is kept.handoff.py saveandverify_gate.py runboth create the directory through that helper.docs/handoff.mdanddocs/verify-gate.mddescribe the new behavior. A handoff written by hand, without the tools, still needs.stackwich/ignored; the policy wording for that is Trim the policy block to a word budget enforced in CI #41.Verification
.stackwich/.gitignoreis kept, passed before and after, as intended.cd tools && python3 -m unittest discover -v: 48 passed, up from 45, with none skipped.cd measured && python3 -m unittest -v test_measured: OK, andapprove.py --self-checkreportsSOD: PASS.validate.yml, run locally: OK.verify_gate.py run, thenhandoff.py save, thengit add -A.main's tools,.stackwich/handoff-files.json,.stackwich/handoff.md,.stackwich/verify.jsonlandapp.pyare staged.app.pyis staged.This branch is independent of #43.
Generated by Claude Code