Repository navigation
test: add Terminal Control PR guards - #89
Merged
Merged
Conversation
oribarilan
marked this pull request as ready for review
October 7, 2026 18:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add separate Terminal Control integration and real-host E2E guards to PR CI, without changing vimcode runtime behavior or the existing fast suite.
just testretains the 355 fast tests.just test-intruns harness parser, SDK/process lifecycle, and launcher checks.just test-e2eselects both pinned hosts by default: OpenCode v1 1.18.34 and v2 2.0.15. Optional host selectors, inferred temporary paths, and local path-only settings are supported.Host and driver processes use isolated state, bounded requests, and owned-process cleanup. The private Terminal Control 1.2.1 lifecycle boundary and current validation limits are documented in
docs/test-e2e.md.Validation
Validated on macOS arm64:
just check: lint and 355 fast tests passed.just test-int: 24 harness checks passed.just compat-unit: 16 tests passed.Ubuntu CI passed on commit
88a7fc8:check,Harness integration tests,E2E tests (v1), andE2E tests (v2). Both E2E jobs also passed their no-plugin negative controls.Notes and follow-up
ENOTCONN; the verified native-binary override passed. CI provisions its pinned hosts explicitly..env.templateis included for optional local path settings. Local.envfiles remain ignored and are not committed.No product-source or existing Python compatibility-harness changes are included. Required-status branch protection is a separate owner action after the new checks run successfully.