Repository navigation
feat: add :w and :write actions to send the prompt - #60
Merged
Merged
Conversation
Previously typing :w in the command palette autocompleted to :wq and quit OpenCode. Vim users hit :w reflexively to save, so map it to the closest equivalent here: dispatch input.submit. :write is the long form. The :wq quit command is unaffected.
Open
Owner
|
@Croos3r I was away on a vacation and only got to this now, sorry for the delay. This looks great, Thanks for the contribution! |
oribarilan
added a commit
that referenced
this pull request
Aug 31, 2026
index.ts 395->408 after the :w/:write merge (#60); types/state/normal drift from the pending-state consolidation.
oribarilan
added a commit
that referenced
this pull request
Sep 1, 2026
Splits the monolithic `src/vim.ts` (656 lines) into a focused `src/vim/` module tree behind a thin barrel, with tests split to mirror the layout. Rebased on v0.16.0. ### What changed - **Module split:** `src/vim.ts` becomes `src/vim/` with one concern per file: `types`, `text`, `tables`, `util`, `state`, `insert`, `normal`, `visual`, plus an `index.ts` barrel that re-exports only the public surface. Handlers stay pure; nothing under `src/vim/` touches the plugin `api`. - **Pending state:** consolidated the two pending-state fields into a single discriminated union. This also fixes a bug where `dgg` and `drx` left a dangling delete operator that corrupted the next motion. - **Tests:** `test/vim.test.ts` split into per-module suites under `test/vim/`, plus a new `test/integration.test.ts` for the full pipeline. - **Docs:** added the modularization and text-objects design notes under `docs/plans/`, and updated AGENTS.md to describe the new layout. ### Behavior No user-facing behavior change beyond the dangling-operator fix. The `:w`/`:write` feature from #60 is untouched (it lives in `src/index.ts`, outside the engine). ### Verification `just check` passes locally: lint clean (24 files), 209 tests, 0 fail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation of the
:wand:writeactions:I did not added any tests because
:wqwas not tested, but I can add some if needed.The old behavior documented in #59 is now replaced by an exact match with
:wso the frustrating:wqcannot be accessed like this.I took the initiative to update the changelog, but feel free to update it if needed, I can also do it on your instructions.