Skip to content

OCPBUGS-116848: Add Sovereign cloud feature gate and UniverseDomain field to GCPPlatformStatus - #3022

Open
barbacbd wants to merge 7 commits into
openshift:release-4.22from
barbacbd:OCPBUGS-116848
Open

OCPBUGS-116848: Add Sovereign cloud feature gate and UniverseDomain field to GCPPlatformStatus#3022
barbacbd wants to merge 7 commits into
openshift:release-4.22from
barbacbd:OCPBUGS-116848

Conversation

@barbacbd

@barbacbd barbacbd commented Sep 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Adds tech preview
  • Adds Dev preview
  • Adds Universe Domain field to GCP Platform status

rochacbruno and others added 5 commits September 2, 2026 12:54
@rochacbruno @barbacbd @claude
CORS-4417: Add UniverseDomain field to GCPPlatformStatus
8bd5b5c 
Adds a universeDomain field to GCPPlatformStatus, gated behind the
GCPSovereignCloudInstall feature gate. This field reports the GCP
universe domain for the cluster as detected from installer credentials,
enabling components without their own GCP credentials to determine the
correct universe domain to use.

The field validates as a DNS subdomain (RFC 1123) with a maximum length
of 253 characters. When omitted, standard public GCP (googleapis.com)
is assumed.

Supersedes openshift#2933 (rebased to resolve conflicts, original author on PTO).

Co-Authored-By: Brent Barbachem <barbacbd@gmail.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@rochacbruno @claude @barbacbd
Address review comments: improve docs and test coverage
520fea1 
- Document MinLength=1 constraint in universeDomain field comment
- Add boundary tests for empty string and >253 char domains
- Add onUpdate tests for ControllerConfig (valid and invalid universeDomain)
- Regenerate CRD manifests, swagger docs, and OpenAPI

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@barbacbd
- Remove universeDomain from DevPreviewNoUpgrade CRDs — the first che…
019fbdc 
…rry-pick commit already added it to CustomNoUpgrade and DevPreviewNoUpgrade, but this second commit is adjusting the generated manifests. The diff removes universeDomain from several DevPreview CRDs and the AzureClusterHostedDNSInstall featuregated manifest, and trims down the GCPSovereignCloudInstall featuregated manifests.

- Deletes SelfManagedHA-* payload CRDs — these don't exist in release-4.22.
@barbacbd
CORS-4435: GCP Sovereign Cloud Feature Gate
757f038 
  - Name: GCPSovereignCloudInstall (with "Install" prefix as required for installer feature gates)
  - Location: features/features.go:875-881
  - Jira Component: "Installer"
  - Contact: barbacbd
  - Enhancement PR: openshift/enhancements#1977
  - Enabled in: TechPreviewNoUpgrade and DevPreviewNoUpgrade

  Generated Files Updated:
  - features.md - Documentation showing the feature gate is enabled in TechPreview and DevPreview
  - Multiple feature gate manifest files for both Hypershift and SelfManagedHA cluster profiles

  The feature gate follows the same pattern as the existing FeatureGateAWSEuropeanSovereignCloudInstall
  for AWS sovereign cloud support, making it consistent with similar installer features.

Authored by claude and reviewed by @barbacbd
@barbacbd
Dev Preview updates to yaml files.
19c023c
@openshift-merge-bot

openshift-merge-bot Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Sep 2, 2026
@openshift-ci-robot

openshift-ci-robot commented Sep 2, 2026

Copy link
Copy Markdown

@barbacbd: This pull request references Jira Issue OCPBUGS-116848, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-116845 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-116845 targets the "5.0" version, which is one of the valid target versions: 5.0.0
  • bug has dependents

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Sep 2, 2026 •
edited
Loading

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: ee7f7b3c-926e-4eb2-b116-d87b9e29d7c5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Hello @barbacbd! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci Bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 2, 2026
@openshift-ci-robot

openshift-ci-robot commented Sep 2, 2026

Copy link
Copy Markdown

@barbacbd: This pull request references Jira Issue OCPBUGS-116848, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-116845 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-116845 targets the "5.0" version, which is one of the valid target versions: 5.0.0
  • bug has dependents
Details

In response to this:

  • Adds tech preview
  • Adds Dev preview
  • Adds Universe Domain field to GCP Platform status

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@everettraven

everettraven commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

/lgtm
/approve

/label backport-risk-assessed

@openshift-ci openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Sep 2, 2026
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 2, 2026
@openshift-merge-bot

openshift-merge-bot Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-hypershift
/test e2e-aws-ovn-hypershift-conformance
/test e2e-aws-ovn-techpreview
/test e2e-aws-serial-1of2
/test e2e-aws-serial-2of2
/test e2e-aws-serial-techpreview-1of2
/test e2e-aws-serial-techpreview-2of2
/test e2e-azure
/test e2e-gcp
/test e2e-upgrade
/test e2e-upgrade-out-of-change

@openshift-ci

openshift-ci Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: everettraven

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 2, 2026
@openshift-ci

openshift-ci Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

@barbacbd: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-serial-2of2 7b09db0 link true /test e2e-aws-serial-2of2

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@everettraven everettraven Awaiting requested review from everettraven
@sinnykumari sinnykumari Awaiting requested review from sinnykumari

Assignees

@everettraven everettraven

@gangwgr gangwgr

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@barbacbd @openshift-ci-robot @everettraven @gangwgr @rochacbruno @patrickdillon