Repository navigation
Conversation
Residues added before residue 1 were numbered from 9999 instead of -1, because the id was taken modulo 10000. PDBFile.writeFile() already falls back to its own numbering for ids that don't fit the PDB format, so the modulo isn't needed. Fixes openmm#175
Contributor
Author
|
@peastman would you please take a look if getting a chance? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Residues added before residue 1 were numbered from 9999 instead of -1, because the id was taken modulo 10000. PDBFile.writeFile() already falls back to its own numbering for ids that don't fit the PDB format, so the modulo isn't needed.
Fixes #175
When residues are missing before the first resolved residue, PDBFixer numbers the new ones by counting back from it. The id was then taken modulo 10000, which turns negative ids into large positive ones, so a residue that should be -1 became 9999.
This removes the modulo, as discussed in the issue. PDBFile.writeFile() already falls back to its own numbering for ids that don't fit the PDB format, so nothing else is needed.
I added a test with a short chain whose SEQRES starts two residues before residue 1. It checks that the added residues are numbered -1 and 0. On master it fails with 9999.
I used Claude Code to help reproduce the bug and write the test.