Skip to content

Don't wrap the ids of added residues at 10000 - #361

Open
aiscihub wants to merge 1 commit into
openmm:masterfrom
aiscihub:added-residue-ids
Open

aiscihub wants to merge 1 commit into
openmm:masterfrom
aiscihub:added-residue-ids

Conversation

@aiscihub

Copy link
Copy Markdown
Contributor

Residues added before residue 1 were numbered from 9999 instead of -1, because the id was taken modulo 10000. PDBFile.writeFile() already falls back to its own numbering for ids that don't fit the PDB format, so the modulo isn't needed.

Fixes #175

When residues are missing before the first resolved residue, PDBFixer numbers the new ones by counting back from it. The id was then taken modulo 10000, which turns negative ids into large positive ones, so a residue that should be -1 became 9999.

This removes the modulo, as discussed in the issue. PDBFile.writeFile() already falls back to its own numbering for ids that don't fit the PDB format, so nothing else is needed.

I added a test with a short chain whose SEQRES starts two residues before residue 1. It checks that the added residues are numbered -1 and 0. On master it fails with 9999.

I used Claude Code to help reproduce the bug and write the test.

Residues added before residue 1 were numbered from 9999 instead of -1,
because the id was taken modulo 10000. PDBFile.writeFile() already falls
back to its own numbering for ids that don't fit the PDB format, so the
modulo isn't needed.

Fixes openmm#175
@aiscihub

Copy link
Copy Markdown
Contributor Author

@peastman would you please take a look if getting a chance?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pdbfixer is mislabeling built residues with negative res IDs

1 participant