Repository navigation
Support insertion codes in applyMutations() - #359
Merged
Merged
Conversation
Residues were looked up by number only, so two residues that differed only by insertion code (e.g. 9 and 9A) collided and only the last one could be mutated. Look them up by number and insertion code, and accept mutations such as GLY-9A-ALA. Fixes openmm#280.
aiscihub
commented
Nov 10, 2026
aiscihub
left a comment
Contributor
Author
There was a problem hiding this comment.
Write the fix and tests.
Contributor
Author
|
@peastman would you please take a look at this pr and merge if looks good? thank you very much! |
Run addMissingAtoms() in test_mutate_insertion_code so the test checks the complete side chains, and update a comment to say that residues are now identified by number and insertion code.
Member
|
This looks good, but the builds are failing to run. I'll debug it separately. |
Contributor
Author
|
Thank you for looking! The builds are failing because |
Member
|
Can you merge the main branch into this PR? That should get the tests running. |
aiscihub
commented
Nov 16, 2026
aiscihub
left a comment
Contributor
Author
There was a problem hiding this comment.
Done, thank you for looking.
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Residues were looked up by number only, so two residues that differed only by insertion code (e.g. 9 and 9A) collided and only the last one could be mutated. Look them up by number and insertion code, and accept mutations such as GLY-9A-ALA. Fixes #280.