Skip to content

add MMCIF output format support - #354

Open
ChrisInBed wants to merge 1 commit into
openmm:masterfrom
ChrisInBed:mmcif_support
Open

ChrisInBed wants to merge 1 commit into
openmm:masterfrom
ChrisInBed:mmcif_support

Conversation

@ChrisInBed

Copy link
Copy Markdown

If the input file format support MMCIF format, then the output file should too.
The new pdbfixer.py decides output file format from the appendix of the output file name, if it ends with .cif then the output file would be in MMCIF format.

@peastman

peastman commented Sep 9, 2026

Copy link
Copy Markdown
Member

Looks good. I have a couple of suggestions.

Just like how it writes a comment at the top of PDB files with the source, it should do the same with PDBx/mmCIF:

if fixer.source is not None:
    f.write("# PDBFixer from: %s\n" % fixer.source)

It also should update the description of the argument:

parser.add_option('--output', default='output.pdb', dest='output', metavar='FILENAME', help='output PDB or PDBx/mmCIF file [default: output.pdb]')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants