Repository navigation
add MMCIF output format support - #354
Open
ChrisInBed wants to merge 1 commit into
Open
ChrisInBed wants to merge 1 commit into
ChrisInBed wants to merge 1 commit into
Conversation
Member
|
Looks good. I have a couple of suggestions. Just like how it writes a comment at the top of PDB files with the source, it should do the same with PDBx/mmCIF: if fixer.source is not None:
f.write("# PDBFixer from: %s\n" % fixer.source)It also should update the description of the argument: parser.add_option('--output', default='output.pdb', dest='output', metavar='FILENAME', help='output PDB or PDBx/mmCIF file [default: output.pdb]') |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the input file format support MMCIF format, then the output file should too.
The new
pdbfixer.pydecides output file format from the appendix of the output file name, if it ends with.cifthen the output file would be in MMCIF format.