Repository navigation
migrate to pyproject.toml - #463
mikemhenry wants to merge 5 commits into
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #463 +/- ##
==========================================
- Coverage 84.48% 84.46% -0.02%
==========================================
Files 5 5
Lines 799 798 -1
==========================================
- Hits 675 674 -1
Misses 124 124 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
mattwthompson
left a comment
There was a problem hiding this comment.
Some quibbles in passing but I personally like the tooling changes included here
| from . import _version | ||
|
|
||
| __version__ = _version.get_versions()["version"] | ||
| from ._version import __version__ |
There was a problem hiding this comment.
Probably want
from importlib.metadata import version
__version__ = version("openmmforcefields")
There was a problem hiding this comment.
I still write out a version file:
(from pyproject.toml)
[tool.setuptools_scm]
version_file = "openmmforcefields/_version.py"
So this is correct, I did that since it works + it would save someone who uses that file downstream, but if you think that isn't worth saving then I can not write out that file + use the method you suggest.
| dynamic = ["version"] | ||
| readme = "README.md" | ||
| authors = [ | ||
| { name = "Chodera lab // MSKCC", email = "john.chodera@choderalab.org" }, |
There was a problem hiding this comment.
@peastman @tmarkland Should we add another entry for us and/or Stanford?
| { name = "Chodera lab // MSKCC", email = "john.chodera@choderalab.org" }, | ||
| ] | ||
| license = "MIT" | ||
| keywords = ["molecular mechanics", "forcefield", "OpenMM", "AMBER", "CHARMM", "GAFF"] |
There was a problem hiding this comment.
Should we add "OpenFF" or "Open Force Field"?
|
Thanks for the feedback everyone! One more bit I will add (as well as the other stuff y'all mentioned) is a CI test for building the wheel + then running the tests via the env resolved from installing the build wheel. That should catch any issues someone might have when pip installing the package. |
Co-authored-by: Matt Thompson <matt.thompson@openforcefield.org> Co-authored-by: Evan Pretti <pretti@stanford.edu>
|
We will need to merge in #462 before this one (to fix the issues with the |
No description provided.