Skip to content

migrate to pyproject.toml - #463

Open
mikemhenry wants to merge 5 commits into
openmm:mainfrom
mikemhenry:migrate-to-pyproject.toml
Open

mikemhenry wants to merge 5 commits into
openmm:mainfrom
mikemhenry:migrate-to-pyproject.toml

Conversation

@mikemhenry

Copy link
Copy Markdown
Collaborator

No description provided.

@codecov-commenter

codecov-commenter commented Nov 20, 2026 •

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.46%. Comparing base (0edd3bb) to head (b22c147).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #463      +/-   ##
==========================================
- Coverage   84.48%   84.46%   -0.02%     
==========================================
  Files           5        5              
  Lines         799      798       -1     
==========================================
- Hits          675      674       -1     
  Misses        124      124              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mikemhenry
mikemhenry marked this pull request as ready for review November 20, 2026 21:38
@mikemhenry
mikemhenry requested a review from epretti November 20, 2026 21:38

@mattwthompson mattwthompson left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some quibbles in passing but I personally like the tooling changes included here

Comment thread pyproject.toml Resolved
from . import _version

__version__ = _version.get_versions()["version"]
from ._version import __version__

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably want

from importlib.metadata import version

__version__ = version("openmmforcefields")

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still write out a version file:
(from pyproject.toml)

[tool.setuptools_scm]
version_file = "openmmforcefields/_version.py"

So this is correct, I did that since it works + it would save someone who uses that file downstream, but if you think that isn't worth saving then I can not write out that file + use the method you suggest.

Comment thread pyproject.toml
dynamic = ["version"]
readme = "README.md"
authors = [
{ name = "Chodera lab // MSKCC", email = "john.chodera@choderalab.org" },

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peastman @tmarkland Should we add another entry for us and/or Stanford?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, definitely.

Comment thread pyproject.toml Resolved
Comment thread pyproject.toml Outdated
{ name = "Chodera lab // MSKCC", email = "john.chodera@choderalab.org" },
]
license = "MIT"
keywords = ["molecular mechanics", "forcefield", "OpenMM", "AMBER", "CHARMM", "GAFF"]

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add "OpenFF" or "Open Force Field"?

@mikemhenry

Copy link
Copy Markdown
Collaborator Author

Thanks for the feedback everyone! One more bit I will add (as well as the other stuff y'all mentioned) is a CI test for building the wheel + then running the tests via the env resolved from installing the build wheel. That should catch any issues someone might have when pip installing the package.

mikemhenry and others added 3 commits November 20, 2026 15:37
Co-authored-by: Matt Thompson <matt.thompson@openforcefield.org>
Co-authored-by: Evan Pretti <pretti@stanford.edu>
@mikemhenry

Copy link
Copy Markdown
Collaborator Author

We will need to merge in #462 before this one (to fix the issues with the CI / Build and test installed wheel test)

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants