Repository navigation
fix: point the email change confirmation to account settings - #39333
ihor-romaniuk wants to merge 1 commit into
Conversation
|
Thanks for the pull request, @ihor-romaniuk! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
The page shown after a learner confirms an email change said the new address is visible on the dashboard, which never shows it. Link to the Account MFE (honouring site configuration) where the email is shown.
700e716 to
b93626d
Compare
Description
After a learner confirms an email change, the confirmation page says "You should see your new email in your dashboard" and links to the learner dashboard. The dashboard never shows the learner's email, so the message sends people to the wrong place. The page now says the new email can be seen in the account settings and links to the Account MFE, where the email is shown.
The link honours a per-site
ACCOUNT_MICROFRONTEND_URLin site configuration, falling back to the Django setting, the same way the/account/settingsredirect resolves it.User roles affected: Learner.
Screenshots
Supporting information
Supersedes #36404, which was closed for inactivity. That change linked the page with
reverse('account_settings'), but no URL pattern carries that name (/account/settingsis unnamed), so the page would raiseNoReverseMatch. This one reads the Account MFE URL directly instead.Testing instructions
/email_confirm/<key>).ACCOUNT_MICROFRONTEND_URLset in a site's configuration, the link points to that URL instead.Automated:
pytest common/djangoapps/student/tests/test_email.py -k "EmailChangeSuccessfulPageTests or EmailChangeConfirmationTests". The newEmailChangeSuccessfulPageTestsgo through the real view and template, and fail on the old template.Other information
The translatable string changes from "dashboard" to "account settings", so existing translations of this sentence fall back to English until they are updated.