Skip to content

fix: point the email change confirmation to account settings - #39333

Open
ihor-romaniuk wants to merge 1 commit into
openedx:masterfrom
ihor-romaniuk:fix/email-change-confirmation-account-link
Open

ihor-romaniuk wants to merge 1 commit into
openedx:masterfrom
ihor-romaniuk:fix/email-change-confirmation-account-link

Conversation

@ihor-romaniuk

@ihor-romaniuk ihor-romaniuk commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Description

After a learner confirms an email change, the confirmation page says "You should see your new email in your dashboard" and links to the learner dashboard. The dashboard never shows the learner's email, so the message sends people to the wrong place. The page now says the new email can be seen in the account settings and links to the Account MFE, where the email is shown.

The link honours a per-site ACCOUNT_MICROFRONTEND_URL in site configuration, falling back to the Django setting, the same way the /account/settings redirect resolves it.

User roles affected: Learner.

Screenshots

Before After
before-verawood-email-confirm after-verawood-email-confirm

Supporting information

Supersedes #36404, which was closed for inactivity. That change linked the page with reverse('account_settings'), but no URL pattern carries that name (/account/settings is unnamed), so the page would raise NoReverseMatch. This one reads the Account MFE URL directly instead.

Testing instructions

  1. Sign in as a learner and change the email in Account settings.
  2. Open the confirmation link from the email sent to the new address (/email_confirm/<key>).
  3. The page reads "You should see your new email in your account settings", and the link opens the Account MFE.
  4. With ACCOUNT_MICROFRONTEND_URL set in a site's configuration, the link points to that URL instead.

Automated: pytest common/djangoapps/student/tests/test_email.py -k "EmailChangeSuccessfulPageTests or EmailChangeConfirmationTests". The new EmailChangeSuccessfulPageTests go through the real view and template, and fail on the old template.

Other information

The translatable string changes from "dashboard" to "account settings", so existing translations of this sentence fall back to English until they are updated.

@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Nov 2, 2026
@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @ihor-romaniuk!

This repository is currently maintained by @openedx/wg-maintenance-openedx-platform-oncall.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

The page shown after a learner confirms an email change said the new
address is visible on the dashboard, which never shows it. Link to the
Account MFE (honouring site configuration) where the email is shown.
@ihor-romaniuk
ihor-romaniuk force-pushed the fix/email-change-confirmation-account-link branch from 700e716 to b93626d Compare November 3, 2026 11:56

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U

Projects

Status: Needs Triage

Development

Successfully merging this pull request may close these issues.

2 participants