feat(html): the viewer states whether a click opens a sheet cell - #912
Merged
Merged
Conversation
The pointer decides whether a click opens a cell's editor, and it is a guess: an android WebView reports `(pointer: coarse)` as false on an emulator, so the tap-to-edit of #908 did not happen there at all. `odr.editing.setSheetOptions({editOnClick})` lets the viewer state it, as `odr.annotation.setOptions` states the marking gestures. Unstated, the pointer answers as before. Checked with `test/browser/sheet` - 77 checks on the editing page, none failing, seven of them new. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FJJdfqpnVCKBNHXjAVxSou
andiwand
force-pushed
the
feat/the-viewer-states-the-sheet-gesture
branch
from
September 20, 2026 09:53
c38ab42 to
cf8e01c
Compare
…g as off
`setSheetOptions({editOnClick: undefined})` set the key, so `!== null` took it
as a stated no and a tap opened nothing. `!= null` reads both null and
undefined as unstated, which is what a host passing a value it does not have
means.
The design doc said a double click is what opens the editor, which #908 and
this one no longer make true.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0149gFxhkvKTBQidz6brU8Vt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #908, which asks the pointer whether a click edits. The pointer is a guess, and it is wrong where it matters: an android WebView reports
(pointer: coarse)as false on an emulator, so the tap-to-edit that PR is for did not happen there at all - measured on a Pixel 6 Pro AVD,matchMedia("(pointer: coarse)").matches === falsewith editing enabled and a tap landing on the cell.The viewer knows its input model; the library is guessing at it. So
odr.editing.setSheetOptions({editOnClick})states it, the wayodr.annotation.setOptionsalready states the marking gestures. Unstated (null), the pointer answers exactly as it does today, so nothing changes for a viewer that says nothing.Checked
test/browser/sheet/editing.html: 77 checks, none failing, seven of them new - the default asks the pointer, stated off a click opens nothing while the double click still works, stated on one click opens the cell with its text and pins it, and an unknown option throws.