Skip to content

chore(backend): remove services and repository no production code constructs (#710) - #1501

Open
alex-dembele wants to merge 2 commits into
developfrom
chore/710-remove-dead-services
Open

alex-dembele wants to merge 2 commits into
developfrom
chore/710-remove-dead-services

Conversation

@alex-dembele

Copy link
Copy Markdown
Member

Closes #710

What

Removes backend code that no production path constructs, written against tables the startup schema never builds.

Verification (backend/)

go build ./...            OK
go vet ./...              exit 0
go test -count=1 ./...    all ok, no FAIL
git diff origin/develop -- backend/cmd/server/main.go | wc -l   → 0
route calls in main.go before/after: 508 / 508, diff empty

Review

  • code-reviewer: REVIEW: PASS on f7edca56
  • devsecops: SECURITY: PASS on f7edca56

Not done

  • scripts/risk/rules.json:14 still matches the deleted multitenancy_repository.go. It only raises risk class and is harmless. Editing scripts/risk is out of scope.
  • The legacy SQL migration 20260317_add_multitenancy.sql still creates user_sessions, organization_roles and notification_* tables nothing reads. Dropping them is irreversible and needs its own issue.

…structs (#710)

NotificationService, MultitenantOrgService (+ its unrouted handler),
GormOrganizationRoleRepository and the multitenancy repository interfaces
had no production caller and wrote to tables the startup schema never
builds. Their now-unused domain models (NotificationTemplate,
NotificationLog, OrganizationRole, UserSession) go with them, and the
#710 entries leave knownMissingTables. Profile and ProfilePermission stay:
Organization and OrganizationMember still reference them.

The route list in main.go is unchanged.

Signed-off-by: alex-dembele <alexandredembele16@gmail.com>
…on (#710)

The deleted organisation-role repository held the only cross-organisation
negative test of the organisation write path. Restate it against
tenantwrite directly, and point the ROADMAP notifications row at the live
code.

Signed-off-by: alex-dembele <alexandredembele16@gmail.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove backend services and a repository no production code constructs

1 participant