Repository navigation
fix(ui): make three recorded-as-shipped controls reachable again (#591) - #1496
Merged
Merged
Conversation
…ddressable (#591) Signed-off-by: alex-dembele <alexandredembele16@gmail.com>
…hem (#591) Signed-off-by: alex-dembele <alexandredembele16@gmail.com>
… superseded (#591) Signed-off-by: alex-dembele <alexandredembele16@gmail.com>
#591) Signed-off-by: alex-dembele <alexandredembele16@gmail.com>
…cality level (#591) Signed-off-by: alex-dembele <alexandredembele16@gmail.com>
This was referenced Nov 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #591
The three controls the issue lists all shipped. Two were later replaced by redesigns, and the specs kept testing the old screens. The third failed because of a selector collision and an empty seed.
46344624)/assets/universeredirects to the topology; the filter lives in its Display popover458d8f65, 2026-08-18: export, exact name, MFA, 30-day grace)auth_useralso lackedorg_name, so the button could never enablegetByTitle('Table')matched the "Tableau de bord" link; the seed had no mitigation, so the board showed its empty stateChanges
?view=table|gantt. The toggles getaria-pressedand test ids. The kanban column "+" gets an accessible name: axe raised a criticalbutton-nameonce the board had data. New unit test.SettingsScreenis corrected.docs/JOURNAL.mdanddocs/ui/dead-controls.md. The claim matrix has no row on these controls.Verification
Run against a live throwaway stack (pg16 + redis, backend, Vite) as the admin persona:
Before the fix, the three original cases failed 6/6 with the errors quoted in the issue.
Other checks:
npx tsc -b --noEmit: exit 0.Pre-existing E2E failures (not this branch)
The full suite on this branch gives 247 passed, 36 failed and 15 skipped. I compared it with
origin/developon a fresh database:a11y: Mitigations. It is fixed in this PR.Review
8e128577, then PASS on the delta through8923b782.What's left
/riskswithout checkingmitigations:create. That predates this PR and is unchanged here.CI
Every check passes: 21 pass, 2 skipping (nightly firefox/webkit and the Docker image, as expected).
The first two attempts of Frontend Unit Tests failed in
customFrameworkImportPage.test.tsx, a compliance test this diff does not touch. The third attempt passed. That test has a race: it clicks the import button before the button is enabled. It is tracked in #1497 and fixed by #1498.