Skip to content

fix(ui): make three recorded-as-shipped controls reachable again (#591) - #1496

Merged
alex-dembele merged 5 commits into
developfrom
bug/591-unreachable-datatable-controls
Nov 21, 2026
Merged

alex-dembele merged 5 commits into
developfrom
bug/591-unreachable-datatable-controls

Conversation

@alex-dembele

@alex-dembele alex-dembele commented Nov 20, 2026 •

Copy link
Copy Markdown
Member

Closes #591

The three controls the issue lists all shipped. Two were later replaced by redesigns, and the specs kept testing the old screens. The third failed because of a selector collision and an empty seed.

Control Verdict Why the case failed
Asset Universe funnel shipped, then superseded (page removed 2026-08-12, 46344624) /assets/universe redirects to the topology; the filter lives in its Display popover
Delete organization shipped, then superseded (458d8f65, 2026-08-18: export, exact name, MFA, 30-day grace) old dialog and test id gone; the E2E auth_user also lacked org_name, so the button could never enable
Mitigations table shipped with its test id getByTitle('Table') matched the "Tableau de bord" link; the seed had no mitigation, so the board showed its empty state

Changes

  • Mitigations board: the view follows ?view=table|gantt. The toggles get aria-pressed and test ids. The kanban column "+" gets an accessible name: axe raised a critical button-name once the board had data. New unit test.
  • Topology: test ids on the criticality options.
  • Danger zone: test ids. The stale comment in SettingsScreen is corrected.
  • E2E seed: 4 assets (one per criticality) and 1 mitigation plan, both idempotent. The seed fails loudly if the plan cannot be created.
  • Specs: they now target the current screens. The danger-zone case never submits, since that would schedule deletion of the E2E tenant.
  • Docs: dated "superseded" notes in docs/JOURNAL.md and docs/ui/dead-controls.md. The claim matrix has no row on these controls.

Verification

Run against a live throwaway stack (pg16 + redis, backend, Vite) as the admin persona:

✓ [chromium]      datatable.spec.ts:333  /risks/mitigations?view=table renders <DataTable> with a real search box
✓ [Mobile Chrome] datatable.spec.ts:333  /risks/mitigations?view=table renders <DataTable> with a real search box
✓ [chromium]      dead-controls.spec.ts:106 Topology (formerly Asset Universe): the criticality filter really filters
✓ [Mobile Chrome] dead-controls.spec.ts:106 Topology (formerly Asset Universe): the criticality filter really filters
✓ [chromium]      dead-controls.spec.ts:139 Settings danger zone: deleting the organization is gated by its exact name
✓ [Mobile Chrome] dead-controls.spec.ts:139 Settings danger zone: deleting the organization is gated by its exact name
✓ [chromium] / [Mobile Chrome] a11y.spec.ts:68 a11y: Mitigations (/mitigations)

Before the fix, the three original cases failed 6/6 with the errors quoted in the issue.

Other checks:

  • npx tsc -b --noEmit: exit 0.
  • vitest on mitigations, attackSurface, billing and settings: 82/82.

Pre-existing E2E failures (not this branch)

The full suite on this branch gives 247 passed, 36 failed and 15 skipped. I compared it with origin/develop on a fresh database:

Review

  • code-reviewer: PASS on 8e128577, then PASS on the delta through 8923b782.
  • devsecops: not needed. The diff touches no backend, auth, tenant, upload or secret code.

What's left

CI

Every check passes: 21 pass, 2 skipping (nightly firefox/webkit and the Docker image, as expected).

The first two attempts of Frontend Unit Tests failed in customFrameworkImportPage.test.tsx, a compliance test this diff does not touch. The third attempt passed. That test has a race: it clicks the import button before the button is enabled. It is tracked in #1497 and fixed by #1498.

…ddressable (#591)

Signed-off-by: alex-dembele <alexandredembele16@gmail.com>
…hem (#591)

Signed-off-by: alex-dembele <alexandredembele16@gmail.com>
… superseded (#591)

Signed-off-by: alex-dembele <alexandredembele16@gmail.com>
#591)

Signed-off-by: alex-dembele <alexandredembele16@gmail.com>
…cality level (#591)

Signed-off-by: alex-dembele <alexandredembele16@gmail.com>
@alex-dembele
alex-dembele added this pull request to the merge queue Nov 21, 2026
Merged via the queue into develop with commit 772ea29 Nov 21, 2026
44 of 49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(ui): three controls the DataTable delivery recorded as shipped are not reachable

1 participant