Skip to content

Update test gnmi3 union_replace - #6132

Open
ijernoiu wants to merge 9 commits into
openconfig:mainfrom
open-traffic-generator:gnmi3-update
Open

ijernoiu wants to merge 9 commits into
openconfig:mainfrom
open-traffic-generator:gnmi3-update

Conversation

@ijernoiu

@ijernoiu ijernoiu commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

@ijernoiu
ijernoiu requested a review from a team as a code owner October 6, 2026 23:34
@OpenConfigBot

OpenConfigBot commented Oct 6, 2026 •

Copy link
Copy Markdown

Pull Request Functional Test Report for #6132 / a92b04e

Virtual Devices

Device Test Status Test Documentation Job Raw Log
Arista cEOS status
gNMI-3: pending authorization
gNMI-3: union_replace
Cisco 8000E status
gNMI-3: pending authorization
gNMI-3: union_replace
Cisco XRd status
gNMI-3: pending authorization
gNMI-3: union_replace
Juniper ncPTX status
gNMI-3: pending authorization
gNMI-3: union_replace
Nokia SR Linux status
gNMI-3: pending authorization
gNMI-3: union_replace
Openconfig Lemming status
gNMI-3: pending authorization
gNMI-3: union_replace

Hardware Devices

Device Test Status Test Documentation Raw Log
Arista status
gNMI-3: pending authorization
gNMI-3: union_replace
Cisco status
gNMI-3: pending authorization
gNMI-3: union_replace
Juniper status
gNMI-3: pending authorization
gNMI-3: union_replace
Nokia status
gNMI-3: pending authorization
gNMI-3: union_replace

Help

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the gnmi3 union_replace test suite to accommodate specific vendor deviations and improve the reliability of configuration verification. It introduces new metadata flags to handle interface validation and origin requirements, while refactoring test logic to better handle CLI-based configuration and breakout mode state verification across different hardware platforms.

Highlights

  • Test Infrastructure Updates: Updated the union_replace test suite to improve robustness, including better handling of CLI configuration, MTU verification, and breakout mode configuration.
  • New Deviations: Added invalid_interface_number_allowed and union_replace_oc_and_cli_required deviations to support specific DUT behaviors during gNMI union_replace operations.
  • Configuration Helpers: Introduced new helper functions like stripShowRunningConfigBanner and requireOCWithCLI to ensure clean configuration inputs and compatibility with strict DUT requirements.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the gNMI union-replace test suite to support Cisco devices and introduces new platform deviations, specifically invalid_interface_number_allowed and union_replace_oc_and_cli_required. It refactors breakout configuration, MTU validation, and port speed verification, including using raw gNMI Get requests to handle vendor-specific speed identities. Additionally, it adds helper functions to strip running configuration banners and manage vendor-specific breakout parameters. The review feedback recommends optimizing the speedValueG helper by defining its regular expression as a package-level variable to avoid recompiling it on every function call.

Comment thread feature/gnmi/tests/union_replace_test/union_replace_test.go
@dplore

dplore commented Oct 7, 2026

Copy link
Copy Markdown
Member

/fptest cisco-8808

@dplore

dplore commented Oct 7, 2026

Copy link
Copy Markdown
Member

/fptest cisco-8808

@dplore

dplore commented Oct 9, 2026

Copy link
Copy Markdown
Member

/fptest cisco-8808

1 similar comment
@dplore

dplore commented Oct 9, 2026

Copy link
Copy Markdown
Member

/fptest cisco-8808

@dplore

dplore commented Oct 9, 2026

Copy link
Copy Markdown
Member

Thank you for this @ijernoiu . Please share test results over private connection and resolve conflicts.

Comment thread proto/metadata.proto Outdated
Comment thread feature/gnmi/tests/union_replace_test/union_replace_test.go Outdated

@dplore dplore left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide the latest logs for all platforms to ensure the test is passing as expected. They can be provided in the referenced tracking bug

Comment thread proto/metadata.proto
@dplore

dplore commented Oct 14, 2026

Copy link
Copy Markdown
Member

(Note, github is also reporting conflicts that must be resolved.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants