Repository navigation
Conversation
Pull Request Functional Test Report for #6132 / a92b04eVirtual Devices
Hardware Devices
|
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the gNMI union-replace test suite to support Cisco devices and introduces new platform deviations, specifically invalid_interface_number_allowed and union_replace_oc_and_cli_required. It refactors breakout configuration, MTU validation, and port speed verification, including using raw gNMI Get requests to handle vendor-specific speed identities. Additionally, it adds helper functions to strip running configuration banners and manage vendor-specific breakout parameters. The review feedback recommends optimizing the speedValueG helper by defining its regular expression as a package-level variable to avoid recompiling it on every function call.
|
/fptest cisco-8808 |
|
/fptest cisco-8808 |
|
/fptest cisco-8808 |
1 similar comment
|
/fptest cisco-8808 |
|
Thank you for this @ijernoiu . Please share test results over private connection and resolve conflicts. |
dplore
left a comment
There was a problem hiding this comment.
Please provide the latest logs for all platforms to ensure the test is passing as expected. They can be provided in the referenced tracking bug
|
(Note, github is also reporting conflicts that must be resolved. |
Update for test gnmi3 union_replace
Identified deviations:
https://partnerissuetracker.corp.google.com/issues/570493628
https://partnerissuetracker.corp.google.com/issues/570523357