Repository navigation
ISIS: cover telemetry gaps in base_adjacencies and isis_scale tests - #6119
ashishpawar-google wants to merge 1 commit into
Conversation
ashishpawar-google
commented
Oct 1, 2026
ashishpawar-google
commented
- base_adjacencies_test: check LSP retransmit counter for presence only, since retransmits are legitimate during initial OTG adjacency bring-up.
- base_adjacencies_test: fall back to level-2 hello-authentication when interface-level authentication config is rejected.
- Add deviation isis_lsp_retransmit_counter_unsupported (Nokia).
- isis_scale_test: verify global SPF first-interval state and add the spf-first-interval telemetry path to the README.
Pull Request Functional Test Report for #6119 / 55dc3f0Virtual Devices
Hardware Devices
|
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on improving the robustness and telemetry coverage of IS-IS tests. It addresses specific gaps in adjacency and scale testing by refining how counters are verified, adding support for platform-specific deviations, and ensuring configuration cleanup is more comprehensive. These changes improve test reliability across different hardware platforms and ensure better alignment with expected telemetry paths. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces support for verifying the IS-IS up-timestamp and retransmit counters, adds checks for the global SPF first interval, and optimizes route counting using AFT summaries. However, there are a few critical issues in the implementation. First, a potential nil pointer dereference exists in NewAggregateInterface when creating aggregate interfaces without IP attributes, as subinterface 0 is accessed unconditionally. Second, the retry loops in findProtocolRouteCount for both IPv4 and IPv6 prematurely break when the route count is zero, defeating the polling mechanism.
0985239 to
a796e84
Compare
|
Passed test logs : SCALE TEST ARISTA : http://sponge2/a77a6243-57c7-4a6a-9344-dbcc90297716 Cisco : http://sponge2/00e33c54-28b7-495b-8356-4b06381d1330 JUNIPER : http://sponge2/7adae118-12ce-43a1-a2d8-25496637ffb9 NOKIA : http://sponge2/6dadd936-0129-4cda-8eb4-e7ed1d9a418e base_adjacencies_test CISCO : http://sponge2/d8cbe5fe-dcaa-472e-9277-c3358d33e12f NOKIA : http://sponge2/6dcea624-082a-4e7d-8347-a6b97ddd4fd4 JUNIPER : http://sponge2/3b25772b-3803-4979-99cd-688410c8c313 |
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces several updates to the IS-IS base adjacency and scale tests, including adding verification for the up-timestamp and retransmit counters, validating the global SPF first interval, and introducing the ISISLspRetransmitCounterUnsupported deviation. It also refactors the aggregate interface configuration in cfgplugins and improves cleanup registration. A critical issue was raised in the review regarding NewAggregateInterface in internal/cfgplugins/interface.go, where subinterface 0 is not created if both IPv4 and IPv6 attributes are empty, causing the RequireRoutedSubinterface0 deviation logic to be skipped. A code suggestion was provided to ensure subinterface 0 is explicitly created and enabled when required.
|
A few verification notes on
|
Update the latest run results on mirror PR. |
a958f00 to
eb23796
Compare
eb23796 to
9ab4287
Compare
base_adjacencies_test (RT-2.1): - Verify adjacency up-timestamp is reported and non-zero. - Check LSP retransmit counter: zero before adjacency, present after (retransmits are legitimate during initial OTG adjacency bring-up). - Fall back to level-2 hello-authentication when interface-level authentication config is rejected by the DUT. - Add deviation isis_lsp_retransmit_counter_unsupported for Nokia (https://partnerissuetracker.corp.google.com/issues/570885559) and regenerate metadata.pb.go. isis_scale_test (RT-2.17): - Verify global SPF first-interval state (200ms) and document the path. - Fix dynamic test DUT data (copy LAG attrs instead of mutating shared attrs; use both LAGs) and enable hierarchical FIB where supported. - Make ISIS adjacency/route-count checks robust: nil-safe level lookup, honor nominal count in non-stream path, prefer AFT summary counters with fallback to per-entry watch, longer convergence timeouts. - Register cleanup before DUT config and also remove LAG interfaces so failed runs don't leak config.
9ab4287 to
55dc3f0
Compare
This branch has not been deployed
4 participants
