Repository navigation
SYS-1.1 Add strata platform support to default_copp_test - #5460
keil-arista wants to merge 1 commit into
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the default_copp_test to support the Strata platform alongside the existing Sand platform. By dynamically detecting the hardware platform via gNMI, the test now correctly selects the appropriate counter mappings for control plane traffic. Additionally, it introduces a new deviation to gracefully handle platform-specific limitations where L2 unicast packets are dropped before reaching the CPU, ensuring test reliability across different Arista hardware models. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
Pull Request Functional Test Report for #5460 / 1125c20Virtual Devices
Hardware Devices
|
There was a problem hiding this comment.
Code Review
This pull request introduces platform-specific COPP (Control Plane Policing) counter validation by dynamically detecting the platform type and mapping logical counters to platform-specific names. It also adds a new deviation, CoppL2UnicastUnsupported, to handle hardware that does not support L2 unicast counter validation. Feedback includes a requirement to add issue tracker links to deviation functions per the style guide, and recommendations to use the test context in gNMI requests within helper functions to ensure proper timeout and cancellation handling.
51cd110 to
6f1b1de
Compare
6f1b1de to
4f4cef5
Compare
4f4cef5 to
4c5e3da
Compare
4c5e3da to
4b6e4e5
Compare
4b6e4e5 to
43f4c4a
Compare
43f4c4a to
f45571c
Compare
f45571c to
59ea1d7
Compare
59ea1d7 to
1125c20
Compare
1125c20 to
da14a85
Compare
The default_copp_test hardcodes "sand" in the OpenConfig vendor path and uses sand-specific counter names. Strata platform devices (e.g. DCS-7050CX4M-48D8-F) require different counter names and a different vendor path element. This change detects the platform dynamically from the gNMI response and selects the appropriate counter mapping. * (M) feature/system/control_plane_traffic/otg_tests/default_copp_test/default_copp_test.go - Add platformConfig struct and counter name maps for sand vs strata. - Replace hardcoded "sand" path element with detected platform name.
da14a85 to
09f8f4a
Compare
The default_copp_test hardcodes "sand" in the OpenConfig vendor path and uses sand-specific counter names. Strata platform devices (e.g. DCS-7050CX4M-48D8-F) require different counter names and a different vendor path element. This change detects the platform dynamically from the gNMI response and selects the appropriate counter mapping.