Skip to content

fix(api): correct custom voice creation parameters - #1153

Merged
marcuswood-oai merged 1 commit into
mainfrom
castiron/promotions/pr-225
Oct 8, 2026
Merged

marcuswood-oai merged 1 commit into
mainfrom
castiron/promotions/pr-225

Conversation

@marcuswood-oai

Copy link
Copy Markdown
Contributor

Summary

Correct voice creation to use the supported consent-based audio upload contract.

Changes

  • Require a consent recording and an audio sample when creating a voice.
  • Keep audio_sample as the documented response type.

Castiron-Internal-PR: openai/openai-java-internal#225
Castiron-Source-SHA: 97850da9d347d82b2f4c3cb4da235f94c97913bd
Castiron-Public-Base-SHA: a0dc1bc
@github-actions

github-actions Bot commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Castiron custom code

Evaluated main: a0dc1bcfcfe0a3834bc85346e3f2e78ec2e74385.

✅ No new custom-code files detected.

102 mixed files remain; 0 existing customizations changed.

Compared a0dc1bcfcfe0 → f4e618d42e80. Generated baselines verified.

102 existing customizations unchanged
  • openai-java-core/src/main/kotlin/com/openai/models/audio/AudioResponseFormat.kt
  • openai-java-core/src/main/kotlin/com/openai/models/beta/agents/vaults/credentials/CredentialAuth.kt
  • openai-java-core/src/main/kotlin/com/openai/models/beta/agents/vaults/credentials/CredentialAuthCreateParam.kt
  • openai-java-core/src/main/kotlin/com/openai/models/beta/agents/vaults/credentials/CredentialAuthRotateParam.kt
  • openai-java-core/src/main/kotlin/com/openai/models/beta/responses/BetaResponse.kt
  • openai-java-core/src/main/kotlin/com/openai/models/beta/responses/BetaResponseInjectEvent.kt
  • openai-java-core/src/main/kotlin/com/openai/models/beta/responses/BetaResponseInjectFailedEvent.kt
  • openai-java-core/src/main/kotlin/com/openai/models/beta/responses/BetaResponseStreamEvent.kt
  • openai-java-core/src/main/kotlin/com/openai/models/beta/responses/BetaResponseToolSearchOutputItemParam.kt
  • openai-java-core/src/main/kotlin/com/openai/models/beta/responses/BetaResponsesServerEvent.kt
  • openai-java-core/src/main/kotlin/com/openai/models/chat/completions/ChatCompletionCreateParams.kt
  • openai-java-core/src/main/kotlin/com/openai/models/chat/completions/ChatCompletionMessageFunctionToolCall.kt
  • openai-java-core/src/main/kotlin/com/openai/models/chat/completions/ChatCompletionToolMessageParam.kt
  • openai-java-core/src/main/kotlin/com/openai/models/conversations/ConversationCreateParams.kt
  • openai-java-core/src/main/kotlin/com/openai/models/conversations/items/ItemCreateParams.kt
  • openai-java-core/src/main/kotlin/com/openai/models/embeddings/Embedding.kt
  • openai-java-core/src/main/kotlin/com/openai/models/embeddings/EmbeddingCreateParams.kt
  • openai-java-core/src/main/kotlin/com/openai/models/live/ResponseItemCreateEvent.kt
  • openai-java-core/src/main/kotlin/com/openai/models/responses/Response.kt
  • openai-java-core/src/main/kotlin/com/openai/models/responses/ResponseCreateParams.kt
  • openai-java-core/src/main/kotlin/com/openai/models/responses/ResponseFunctionToolCall.kt
  • openai-java-core/src/main/kotlin/com/openai/models/responses/ResponseFunctionWebSearch.kt
  • openai-java-core/src/main/kotlin/com/openai/models/responses/ResponseInputItem.kt
  • openai-java-core/src/main/kotlin/com/openai/models/responses/ResponseStreamEvent.kt
  • openai-java-core/src/main/kotlin/com/openai/models/responses/ResponseTextConfig.kt
  • openai-java-core/src/main/kotlin/com/openai/models/responses/ResponseToolSearchOutputItemParam.kt
  • openai-java-core/src/main/kotlin/com/openai/models/responses/ResponsesServerEvent.kt
  • openai-java-core/src/main/kotlin/com/openai/models/videos/Video.kt
  • openai-java-core/src/main/kotlin/com/openai/models/webhooks/UnwrapWebhookEvent.kt
  • openai-java-core/src/main/kotlin/com/openai/models/webhooks/WebhookEndpointWithSecret.kt
  • openai-java-core/src/main/kotlin/com/openai/services/async/BetaServiceAsync.kt
  • openai-java-core/src/main/kotlin/com/openai/services/async/BetaServiceAsyncImpl.kt
  • openai-java-core/src/main/kotlin/com/openai/services/async/ImageServiceAsyncImpl.kt
  • openai-java-core/src/main/kotlin/com/openai/services/async/ResponseServiceAsync.kt
  • openai-java-core/src/main/kotlin/com/openai/services/async/ResponseServiceAsyncImpl.kt
  • openai-java-core/src/main/kotlin/com/openai/services/async/SkillServiceAsyncImpl.kt
  • openai-java-core/src/main/kotlin/com/openai/services/async/VideoServiceAsyncImpl.kt
  • openai-java-core/src/main/kotlin/com/openai/services/async/WebhookServiceAsync.kt
  • openai-java-core/src/main/kotlin/com/openai/services/async/WebhookServiceAsyncImpl.kt
  • openai-java-core/src/main/kotlin/com/openai/services/async/audio/TranscriptionServiceAsyncImpl.kt

62 more in the full report.

A changed generated baseline means this report cannot reliably identify which handwritten lines changed.

Inspect the custom-code diff

Download the exact patch produced by this run (requires repository access):

gh run download 37749924942 --repo openai/openai-java \
  --name castiron-custom-code-37749924942-1 --dir /tmp/castiron-custom-code-37749924942-1
git apply --stat /tmp/castiron-custom-code-37749924942-1/custom-code.patch
cat /tmp/castiron-custom-code-37749924942-1/custom-code.patch

Or reproduce it from an SDK checkout containing the vendored reporter:

git fetch --no-tags origin a0dc1bcfcfe0a3834bc85346e3f2e78ec2e74385 f4e618d42e80b05ebb045e95f8c5bb45f0478e64
python3 scripts/castiron/custom_code_report.py report \
  --base a0dc1bcfcfe0a3834bc85346e3f2e78ec2e74385 \
  --head f4e618d42e80b05ebb045e95f8c5bb45f0478e64 --fetch --require-head-hash --public \
  --out /tmp/castiron-custom-code-f4e618d42e80
cat /tmp/castiron-custom-code-f4e618d42e80/custom-code.patch

This is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR.

Full report and patch

@marcuswood-oai
marcuswood-oai marked this pull request as ready for review October 8, 2026 08:26
@marcuswood-oai
marcuswood-oai requested a review from a team as a code owner October 8, 2026 08:26
@openai-sdks

openai-sdks Bot commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

OkTest Summary

✅ 236/236 SDK tests passed in 15.134s for Java SDK PR #1153.

Test results — 42 files
Test Result Time
tests/chat-completions-complex-body.test.ts ✅ Passed 693ms
tests/chat-completions-create.test.ts ✅ Passed 366ms
tests/chat-completions-stream.test.ts ✅ Passed 524ms
tests/files-content-binary.test.ts ✅ Passed 214ms
tests/files-create-multipart.test.ts ✅ Passed 236ms
tests/files-list-pagination.test.ts ✅ Passed 222ms
tests/initialize-config.test.ts ✅ Passed 122ms
tests/instance-isolation.test.ts ✅ Passed 122ms
tests/models-list.test.ts ✅ Passed 201ms
tests/responses-background-lifecycle.test.ts ✅ Passed 256ms
tests/responses-body-method-errors.test.ts ✅ Passed 448ms
tests/responses-cancel-timeout.test.ts ✅ Passed 219ms
tests/responses-cancel.test.ts ✅ Passed 193ms
tests/responses-compact-retries.test.ts ✅ Passed 385ms
tests/responses-compact.test.ts ✅ Passed 320ms
tests/responses-create-advanced-stream.test.ts ✅ Passed 387ms
tests/responses-create-advanced.test.ts ✅ Passed 1.524s
tests/responses-create-disconnect.test.ts ✅ Passed 1.064s
tests/responses-create-errors.test.ts ✅ Passed 323ms
tests/responses-create-malformed-api-responses.test.ts ✅ Passed 179ms
tests/responses-create-retries.test.ts ✅ Passed 179ms
tests/responses-create-stream-failures.test.ts ✅ Passed 1.451s
tests/responses-create-stream-timeout.test.ts ✅ Passed 205ms
tests/responses-create-stream-wire.test.ts ✅ Passed 5.467s
tests/responses-create-stream.test.ts ✅ Passed 200ms
tests/responses-create-terminal-states.test.ts ✅ Passed 323ms
tests/responses-create-timeout.test.ts ✅ Passed 192ms
tests/responses-create.test.ts ✅ Passed 295ms
tests/responses-delete.test.ts ✅ Passed 254ms
tests/responses-input-items-errors.test.ts ✅ Passed 297ms
tests/responses-input-items-list.test.ts ✅ Passed 385ms
tests/responses-input-items-options.test.ts ✅ Passed 329ms
tests/responses-input-tokens-count-timeout.test.ts ✅ Passed 241ms
tests/responses-input-tokens-count.test.ts ✅ Passed 197ms
tests/responses-malformed-inputs.test.ts ✅ Passed 4.293s
tests/responses-not-found-errors.test.ts ✅ Passed 382ms
tests/responses-parse.test.ts ✅ Passed 485ms
tests/responses-retrieve-retries.test.ts ✅ Passed 240ms
tests/responses-retrieve.test.ts ✅ Passed 245ms
tests/responses-stored-method-errors.test.ts ✅ Passed 1.004s
tests/retry-behavior.test.ts ✅ Passed 3.372s
tests/sdk-error-shape.test.ts ✅ Passed 382ms

View OkTest run #37749874619

SDK merge (80ebacd79a61) · head (f4e618d42e80) · base (a0dc1bcfcfe0) · OkTest (505ac0e34283)

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-08T08:29:06.770904Z f4e618d Draft marked ready
🔒 Security Review ✅ Completed 2026-10-08T08:30:10.701878Z f4e618d Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@marcuswood-oai
marcuswood-oai merged commit 43422a8 into main Oct 8, 2026
16 checks passed
@openai-sdks openai-sdks Bot mentioned this pull request Oct 8, 2026
marcuswood-oai pushed a commit that referenced this pull request Oct 8, 2026
Automated Release PR
---


##
[4.78.1](v4.78.0...v4.78.1)
(2026-10-08)


### Bug Fixes

* **api:** correct custom voice creation parameters
([#1153](#1153))
([43422a8](43422a8))
* **ci:** reuse SDK compilation outputs across Java builds
([#1149](#1149))
([a0dc1bc](a0dc1bc))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: openai-sdks[bot] <284451331+openai-sdks[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant