Repository navigation
fix(desktop): renew sessions while a workspace stays open - #797
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Desktop workspaces left open can keep sending an expired bearer and fail with
401: rejected by guard. The launcher only checked credentials during its own API calls, so an idle embedded workspace could outlive its session.Check the active session every minute, renew workspace sessions during their last day through the existing renewal endpoint, and publish renewed credentials to the embedded workspace. Coalesce concurrent renewals, retain workspace sessions on temporary renewal failures, require sign-in after expiry or refusal, and discard renewal results that arrive after sign-out. Firebase credentials also refresh while the workspace remains open.
Validation: 42 account and IPC tests passed, including background renewal, wake after expiry, temporary failure retry, concurrent renewal, and sign-out races. Launcher TypeScript checks passed.
This requires a new desktop build; a website deployment alone does not update installed desktop clients. No backend or database changes.