Repository navigation
Make OpenLayers webfonts opt-in with download controls - #17
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make OpenLayers font metadata rewriting opt-in with per-style
olWebfonts: true. When omitted or false, preserve upstreamol:webfontsmetadata even if font families are configured, so the proxy does not impose OpenLayers font behavior on other consumers.Keep
webfontsas the separate family/weight download policy. Styles can disable all proxy downloads, a family, or individual normal/italic weights; explicitfalseface entries now return empty CSS instead of raising a configuration error. Existing weight aliases continue to work.When opted in, retain the local metadata template even with downloads disabled, because
applyStyle()treats false metadata as absent. Document configuration examples, cache invalidation, and the upstream rich-text font-loading limitation.Validation:
composer test -- --no-progress(175 tests, 515 assertions, no failures; one existing warning and four skips),composer analyse -- --no-progress(no errors), andgit diff --check.