Repository navigation
feat(kingfisher): Add scrapyd_norestart pillar flag to deploy without restarting Scrapyd - #679
Merged
Merged
Conversation
This was referenced Oct 7, 2026
RobHooper
approved these changes
Oct 8, 2026
RobHooper
left a comment
RobHooper
left a comment
Contributor
There was a problem hiding this comment.
This code all looks sound to me.
One comment:
My preference would be for a simpler, non-site-specific pillar state such as the below. Is there a need for them to be separate, such as restarting registry but not restarting kingfisher?
{"scrapyd_norestart":true}
Member
Author
|
I think the current config works for both, but there's no need to be nesting the pillar data. I'll update. |
jpmckinney
changed the title
jpmckinney
force-pushed
the
scrapyd-norestart
branch
from
October 8, 2026 15:13
6553625 to
1b04dbc
Compare
… restarting Scrapyd Skipping every state that would restart Scrapyd leaves its changes pending, so the next deployment without the flag applies them and restarts Scrapyd. Also split the "Check if Kingfisher is busy" setup step between kingfisher-main and registry. Refs open-contracting/data-registry#442 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VQEQ81K3CxwjzbM2CRT1CE
- Clarify that `in` tests non-boolean keys and `.get()` tests boolean keys, and update the regular expression's list of boolean keys. - Use `in` or `default` instead of `.get()` for non-boolean keys. - Capitalize booleans in the Grafana state. - Rename the `checks.enabled` list to `checks.scheduled`, as `enabled` is otherwise a boolean key. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VQEQ81K3CxwjzbM2CRT1CE
jpmckinney
force-pushed
the
scrapyd-norestart
branch
from
October 8, 2026 16:25
1b04dbc to
2b436ce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skipping every state that would restart Scrapyd leaves its changes pending, so the next
deployment without the flag applies them and restarts Scrapyd.
Also split the "Check if Kingfisher is busy" setup step between kingfisher-main and registry.
Refs open-contracting/data-registry#442
Co-Authored-By: Claude Opus 5.5 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01VQEQ81K3CxwjzbM2CRT1CE