Fix Windows CI: alloc_watch MSVC caller-site intrinsic - #51
Merged
Merged
Conversation
The M1-ALLOC-01 allocation watch captures the first offending allocation's call site via LAIGE_ALLOC_CALLER_SITE(). The MSVC branch spelled the intrinsic GCC-style (__return_address), which does not exist on MSVC — C2065 (undeclared identifier) in all four operator new overrides, failing the windows-msvc Build step on master (run 36030996286, job 107739418055). Use the MSVC _ReturnAddress() intrinsic from <intrin.h> (same caller-frame semantics as __builtin_return_address(0): the address of the allocating call), and update the two doc mentions that repeated the wrong name (docs/api/alloc_watch.md, roadmap/README.md). Verified: the change is inside the _MSC_VER branch only; a fresh canonical Debug g++ build of laige-core compiles warning-free.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI confirmed: the
reopened-triggered run 36034935261 ran the windows-msvc job — build clean (no C2065, no warnings),ctest92/92 passed (74.9 s), all platform-independent jobs green.