Skip to content

[M1-HEAD-01] Fix macOS CI: platform-dependent zero-warn assertion in SecondRunFailsWithoutLogging #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
offdev merged 2 commits into from
Sep 15, 2026
Merged

[M1-HEAD-01] Fix macOS CI: platform-dependent zero-warn assertion in SecondRunFailsWithoutLogging #33

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1abd513
[M1-HEAD-01] Fix macOS CI: platform-dependent zero-warn assertion in …
offdev Sep 15, 2026
0ef9310
Retrigger CI: ci:macos label applied to the PR
offdev Sep 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions tests/laige-sim/engine_tests.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -402,13 +402,21 @@ TEST(EngineRun, SecondRunFailsWithoutLogging) {
laige::Engine engine =
makeEngine(laige::EngineConfig{60, 64, 256});
ASSERT_TRUE(engine.run_headless(1, 1).ok());
// The first run is wall-clock paced: on a loaded runner a frame can
// run longer than one tick of simulation time, and the loop then
// warns (loop/tick_dropped) — the documented M1-LOOP-01 overload
// behavior (the BoundedRun tests above deliberately do not assert
// the drop count for this reason). Those entries belong to the
// first run's accounting, not the stopped-state failure: the
// assertion below is scoped to the SECOND run.
const std::size_t entriesAfterFirstRun = sink->entries.size();
const laige::Status second = engine.run_headless(1, 1);
ASSERT_TRUE(second.isError());
EXPECT_EQ(second.error(), laige::ErrorCode::InvalidArgument);
// The stopped-state failure is a pure failure: no log (the
// GameLoop's moved-out precedent); the Info lifecycle events of
// the first run are below the capture sink's Warn floor anyway.
EXPECT_EQ(sink->entries.size(), 0u);
// both runs are below the capture sink's Warn floor anyway.
EXPECT_EQ(sink->entries.size(), entriesAfterFirstRun);
restoreLogger();
}

Expand Down
Loading