Repository navigation
fix: unbreak mise run apply on the GPU builds - #410
Merged
Merged
Conversation
- Tarball builds have no git history, so llama.cpp resolves BUILD_NUMBER 0 and asks the HF bucket for UI assets tagged "b0". - That bucket does not exist, so it falls back to "latest", whose asset set lacks workbox-*.js and fails the release's own asset validation. - Pass the tag's bNNNN as LLAMA_BUILD_NUMBER so the matching assets are fetched. - Omit the flag for tags without a build number, such as v0.9.0.
- The Tailscale peer list included offline machines. - `hc machine add` needs ssh, so it timed out and logged a warning on every apply. - Filter on .Online so only reachable peers are attempted. - Offline machines are added by the first apply after they reappear.
- llama.cpp and whisper.cpp configure warn when ccache is missing. - Both services rebuild from source on version bumps, so the cache pays off.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
mise run applyfailed inllama:setupand logged a Herdr warning on every run.The llama failure was not a broken toolchain. Tarball builds have no git
history, so llama.cpp resolved
BUILD_NUMBER0, asked the Hugging Face bucketfor UI assets tagged
b0(which does not exist), and fell back tolatest.Those assets come from a newer UI with no
workbox-*.js, so the release's ownasset validator aborted the build before
llama-serverlinked.The Herdr warning was an offline Tailscale peer.
hc machine addneeds ssh, sothe sync timed out on
odsod-x1-carbon(last seen 10 days ago) and reported astanding failure.
What
fix(llama): pass the tag'sbNNNNasLLAMA_BUILD_NUMBERso the bucketserves the assets built for that release. Tags without a build number, such
as
v0.9.0, skip the flag.fix(herdr): only sync peers with.Online == true. Offline machines areadded by the first apply after they reappear.
chore(bootstrap): installccache. Both GPU builds warn when it ismissing, and both rebuild from source on version bumps.
Test plan
mise run applyexits 0mise bootstrap --dry-runreports no pending work/healthreturn 200; llama UI at:8179returns 200with gzip
OKwithsystem_fingerprint: b12359-unknown,which confirms the build number reaches the binary
mise run checkpassesherdr:sync-machinesruns without a warningVerified with
llama_version = "1.0.0-b12359-b1b770d", bumped separately. On0.9.0the new flag is skipped, so this change is inert until that bump lands.