Repository navigation
test(e2e): catch accessibility, overflow, and console regressions (ENG-160) - #117
Merged
Merged
Conversation
…G-160) Axe, mobile overflow, and console guards fail when contrast, min-width, or hydration bugs return. WebKit only runs the smoke tag.
Waiting for the load event stalls on the PM2 post in CI, so the guard never reaches scrollWidth.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@mobileon Pixel 7 for the menu, the inert skip link, and horizontal overflow at 320px and 390px, including every post.@smoketag (home, blog, one post, theme, language).Local proof, restored before this commit: removing
min-w-0from the recent-writinglimade/at 320px reportscrollWidth 593againstclientWidth 320. Setting light--mutedto#767676(3.86:1 on#f2ebeb) made the/privacylight scan failcolor-contrastwith the rule, route, theme, and selector. The suite then passed three times with--retries=0on one reused production server (273 passed in 28.1s, 25.5s, and 26.7s).The
e2ejob ond145ddetook 1m 37s. The budget is at most +3 min on this PR'se2ejob, including install and build.Test plan
min-w-0on the home grid item (scrollWidth 593,clientWidth 320)./privacyfailscolor-contrastwhen--muteddrops below 4.5:1.pnpm exec playwright test --retries=0is green three times on a reused server.e2eis green and within +3 min of 1m 37s.