Repository navigation
fix(a11y): landmark posts, skip to content, and mark the view switch (ENG-155) - #113
Merged
Merged
Conversation
…(ENG-155) Posts sat outside a main landmark, the header took several tabs before the content, and the list/grid links used aria-pressed.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
The hash had no element, so Enter did nothing before hydration and axe flagged skip-link on every page.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<main>, with the back-to-top button inside that landmark and outside.article-frame.aria-current="page"and treat blog and article covers as decorative.Test plan
/and/blog/meu-blog-profissional, the first Tab shows "Pular para o conteúdo" and Enter moves focus tomainwith no outline./blog?view=grid, the active switch item still shows the pill, covers do not repeat the title, and axe reports nolandmark-one-main,region, oraria-allowed-attr.main.