Repository navigation
feat(motion): fade the page in only after the first load (ENG-154) - #111
Merged
Merged
Conversation
Keep the first document paint opaque so the LCP stays the hero or cover, and run the 200ms fade on later client navigations.
Show the bar on click when the next page will fade, and wait one second before the loading message.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
The partial MediaQueryList cast failed tsc, which also took down the production build and e2e.
Hold the bar only while page-in is actually running, so a reused template settles on the next frame instead of waiting out the failsafe.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
page-inends. The corner message waits until the load passes 1s.Delta vs ENG-154
The ticket asked to skip the fade on the initial load (example: an attribute on
<html>set on the first client navigation) and to leave the header, footer, loading bar, and reduced motion unchanged.<html>.PageEnterreads a module flag only in the state initializer, so the class is born on later mounts. An attribute on<html>would match the already painted wrapper again, andanimation-fill-mode: bothwould drop its opacity to 0.page-inends.Lighthouse mobile, median of 3, CLI default. New baseline:
/3394ms (herodaniel_castro_profile_3.jpg); post 2933ms (coverpostgresql-pgadmin-docker-compose.jpg). The ENG-149 comparison of 3388ms vs 3387ms measured the header on both sides.Test plan
/,/about, and a post: no fade, LCP is the image.pnpm testandpnpm test:e2epass.