Skip to content

Validate PR closing references against live issue claims - #27

Merged
zackees merged 2 commits into
masterfrom
fix/26-pr-claim-check
Nov 3, 2026
Merged

zackees merged 2 commits into
masterfrom
fix/26-pr-claim-check

Conversation

@zackees

@zackees zackees commented Nov 3, 2026

Copy link
Copy Markdown
Member

PRs could promise to close a closed, unready or unclaimed issue while still being recommended for enqueue. The claim bot now validates exact closing references against live issue state and accepted claim comments, fails conflicting PR events, and posts one claim-conflict comment. A corrected body/state clears the label on recheck. The coordinator independently refreshes this information before recommending enqueue.

The existing reusable workflow also handles PR and issue-comment events in this repository; caller documentation and the worker skill include the final claim recheck. Documentation-only and CI/test-only paths are exempt. Refs remains suitable for partial work. No workflow files are added.

Refs #26. Consumer activation in obs-rust/obs-studio follows after this reusable implementation is merged; this PR deliberately does not close the issue before that activation.

Validation:

  • RED dfe0ea7: the new regression suite recorded 8 missing-handler errors and the coordinator recommending enqueue for a flagged green PR.
  • GREEN ab0a97d: uv run -m unittest discover -s tests -t . — 224 tests passed; uvx ruff check workflow tests and changed-file formatting passed.
  • Independent local review found missing-reference handling and stale-takeover false positives; both have regression coverage, as does rejected-claim/manual-assignment provenance.

The simulation has existing SQLite ResourceWarnings on successful runs; they do not fail the suite.

@zackees
zackees merged commit 8f5922a into master Nov 3, 2026
3 checks passed
@zackees

zackees commented Nov 3, 2026

Copy link
Copy Markdown
Member Author

Consumer activation is obs-rust/obs-studio#3519 (RED23f3838e6, GREENd1a524453; 57 focused tests passed). The reusable implementation is merged; the consumer PR routes live PR events and is waiting on its required PR gate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant