Transitions - #2
Draft
reuvenharrison wants to merge 2 commits into
Draft
Conversation
The multi-edit shapes recognized as one semantic change join the file: name, description, the kinds of raw findings each suppresses at its shape, and the changes that report it. Their claimed kinds are named claimed_kinds, not claims, since change claims are locations and the two should not share a word. Generator pinned to the oasdiff commit that exports transition metadata. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QDvUFsg5nu1NBWQffErGDw
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QDvUFsg5nu1NBWQffErGDw
reuvenharrison
marked this pull request as draft
September 5, 2026 21:56
Contributor
Author
|
Held as draft until the next oasdiff release: the generator currently pins a pseudo-version of main (for the transitions export), and the model should only publish against released oasdiff versions. When the next release ships, the pin moves to the tag and this merges. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the transitions section, answering the review comment that they were unrepresented: the five multi-edit shapes recognized as one semantic change (boolean-false-schema, list-of-types, null-only-type-change, nullable-wrapping, oneof-wrapping), each with its description, the kinds of raw findings it suppresses at its shape, and the changes that report it.
Naming: the model spells the suppressed kinds
claimed_kindsrather thanclaims, since change claims are locations and the two concepts should not share a word. README and SPEC.md gain the corresponding explanations; SPEC.md's transitions section states the conservation property (nothing is silently dropped; the finding moves from the echoes to the recognition).The generator is pinned to the oasdiff commit that exports transition metadata (oasdiff#1225);
generated_fromshows the pseudo-version honestly until the next oasdiff release, and the exclusive-bounds catalog (oasdiff#1226) will follow in its own PR once merged.