Skip to content

docs: second release review fixes: what 0.9.0 reads, versioned flag claims, fixed review history - #76

Merged
bryanfawcett merged 3 commits into
stagingfrom
docs/release-review-fixes-2
Oct 7, 2026
Merged

bryanfawcett merged 3 commits into
stagingfrom
docs/release-review-fixes-2

Conversation

@bryanfawcett

Copy link
Copy Markdown
Member

Fixes the six findings of the second /code-review pass on the release PR #74.

  1. Medium: 'Nothing new is read from Toddle' in the 0.9.0 notes contradicted the entry's own new views. Now: everything it reads, new included, comes from Toddle as you and stays in the browser; the data handling page lists each read. That page and extensionDataFacts now list the teachers' roles and photos the staff view shows (from what the sidebar already reads; the extension's data schema: no request of its own).
  2. Medium: the 1 October review's version was extensionVersions.current, which will move to 0.9.0 when it ships and rewrite history. Now the fixed '0.8.2', and the security page's 'None was in version 0.8.2' likewise. (The 'reach schools in 0.9.0' line stays a fixed '0.9.0' for the same reason.)
  3. Low/medium: flags.summary and the search featureList said 'never hides' with no version. Both now say from version 0.9.0; the summary is used on the product page.
  4. Low: the student privacy page said the sidebar reads flags each time it opens with no version; it now gives 0.9.0 and what 0.8.2 does (flags.before).
  5. Low: the terms and the product page said 'once a day'; now 'at most once a day', as the privacy policy says.
  6. Low: staging-version.yml gains the same guard as main-version.yml: a manual run tags only on staging.

Verification: astro check 0 errors; npm test 97/97; CSP 5 inline scripts across 14 pages; format:check, vp fmt and markdownlint clean.

🤖 Generated with Claude Code

https://claude.ai/code/session_01GHjaH1Vt2dVLWU68iz8tFq

…laims, fixed review history

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GHjaH1Vt2dVLWU68iz8tFq
@vercel

vercel Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
learning Ready Ready Preview Oct 7, 2026 4:20am UTC

Request Review

bryanfawcett and others added 2 commits October 7, 2026 12:20
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GHjaH1Vt2dVLWU68iz8tFq
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GHjaH1Vt2dVLWU68iz8tFq
@bryanfawcett

Copy link
Copy Markdown
Member Author

Merge-gate record (2026-10-07, release supervisor):

  • /code-review pass 1: 1 medium (flags.summary lost its full stop when made a template; the product page ran two sentences together). Fixed in 267e102 (plus d14b462, a stray blank line). Teacher-read wording confirmed against the extension's docs/data-schema.md.
  • Pass 2 on d14b462: clean.
  • Local: astro check 0 errors; npm test 97/97; CSP 5 inline scripts across 14 pages; format:check, vp fmt and markdownlint clean; built product page checked ('across the room. The switch sits').
  • CI green.

🤖 Generated with Claude Code

@bryanfawcett
bryanfawcett merged commit edba479 into staging Oct 7, 2026
14 checks passed
@bryanfawcett
bryanfawcett deleted the docs/release-review-fixes-2 branch October 7, 2026 04:22
bryanfawcett added a commit that referenced this pull request Oct 7, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GHjaH1Vt2dVLWU68iz8tFq
bryanfawcett added a commit that referenced this pull request Oct 7, 2026
…tension 0.9.0 (#74)

* release: staging to main (2026-10-07)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GHjaH1Vt2dVLWU68iz8tFq

* release: staging to main (2026-10-07): with #75

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GHjaH1Vt2dVLWU68iz8tFq

* release: staging to main (2026-10-07): with #76

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GHjaH1Vt2dVLWU68iz8tFq

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

This branch was successfully deployed

1 active deployment
Preview — d14b462d Deployed Oct 7, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant