Repository navigation
docs: one account of 0.9.0 across the site - #70
Open
bryanfawcett wants to merge 2 commits into
Open
bryanfawcett wants to merge 2 commits into
bryanfawcett wants to merge 2 commits into
Conversation
- The extension page and the Security page say the gradebook's toolbar and the Attendance dashboard's details run in closed shadow roots from 0.9.0, as the releases page and the extension's code (rebuild steps 5 and 7) do; they no longer say these are still moving. - The second review's fixes are in 0.8.4, a test build, and reach schools in 0.9.0, not '0.8.4 before it is published'. - Concealing flags: a new install starts with flags shown; updating from 0.8.2 keeps them concealed. Not 'off until you switch it on'. - llms.txt: the sidebar asks for a student's active flags each time it opens, as legal.ts says. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GHjaH1Vt2dVLWU68iz8tFq Signed-off-by: Bryan Fawcett <bryan@nyuchi.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…ages Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GHjaH1Vt2dVLWU68iz8tFq Signed-off-by: Bryan Fawcett <bryan@nyuchi.com>
Member
Author
|
Review record: /code-review run twice. The first run found 4 issues (security.astro said 0.9.0 was already released; llms.txt left two parts out of the isolated-parts list; the llms.txt flags clause had no version; the product page dropped the 'or you had hidden them yourself' case). All are fixed in f7628de. The second re-review was clean. CI is green. Locally: astro check 0 errors, 96/96 tests pass, the CSP covers 5 inline scripts across 14 pages. Not merged: it is left for the owner while the learning release (#69) is held for extension 0.9.0. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the four findings from /code-review on the release PR #69. Each was a place where the site said two different things.
app/features/gradebook,app/features/attendance-now) confirms the releases page. Both pages now say the same thing.legal.tssay.Verification:
astro check0 errors;npm test96 tests passed, build OK, CSP covers 5 inline scripts across 14 pages;vp fmt --checkclean.🤖 Generated with Claude Code
https://claude.ai/code/session_01GHjaH1Vt2dVLWU68iz8tFq