fs: fix recursive watch error handling - #65635
Open
panva wants to merge 1 commit into
Open
Conversation
nodejs-github-bot
added
fs
Member
Author
|
cc @nodejs/fs |
Recursive watch inverted the throwIfNoEntry check during setup, causing the default behavior to suppress ENOENT while the opt-out threw it. Other setup errors were also silently ignored. Suppress only ENOENT when throwIfNoEntry is false. Propagate all other setup failures and close watchers created before a partial failure. Signed-off-by: Filip Skokan <panva.ip@gmail.com> Assisted-by: Codex
panva
force-pushed
the
fs-recursive-watch-errors
branch
from
August 29, 2026 07:55
7047f05 to
e998475
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #65635 +/- ##
==========================================
+ Coverage 90.04% 90.06% +0.01%
==========================================
Files 754 754
Lines 255722 255723 +1
Branches 48312 48314 +2
==========================================
+ Hits 230274 230315 +41
+ Misses 16553 16548 -5
+ Partials 8895 8860 -35
🚀 New features to boost your workflow:
|
jasnell
approved these changes
Aug 29, 2026
panva
added
author ready
github-actions
Bot
removed
the
request-ci
Collaborator
lpinca
approved these changes
Aug 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recursive watch inverted the
throwIfNoEntrycheck during setup, causing the default behavior to suppressENOENTwhile the opt-out threw it. Other setup errors were also silently ignored.Suppress only
ENOENTwhenthrowIfNoEntryis false. Propagate all other setup failures and close watchers created before a partial failure.