fix(overview): scale focus ring shaders with window previews - #337
Merged
ItsLemmy merged 3 commits intoSep 29, 2026
Merged
Conversation
barrulus
marked this pull request as ready for review
September 28, 2026 19:47
Contributor
|
Thx |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Focus ring details and inner overlays now shrink with overview cards. At
overview.zoom = 0.1, a 40-pixel overlay becomes 4 pixels wide instead of retaining its desktop width.Pass the current overview zoom through the existing effect parameters and account for it when binding shader dimensions, radii, and buffer scale. Border light spread scales with the card, and existing snapshot copying retains the effect scale when a card closes.
Motivation
Closes #324. Overview already scaled the card geometry, but procedural shader distances stayed in desktop-sized pixels.
Type of Change
Testing
All commands ran in the Nix development shell:
meson test -C build-debug -j6 --print-errorlogs: 103 passed.overview/effect_scale,overview/card_lifecycle,effect/border,effect/border_frames,effect/border_transform,effect/window, andeffect/window_capturepassed.just check-stress overview/effect_scale 8: all 8 concurrent runs passed.just lint src/view/effects.cpp src/view/view.cpp src/overview/overview.cpp: passed.just format, formatter verification,bash -n, andgit diff --check: passed.The new pixel regression fails on unchanged main: at 50% zoom, the overlay measures 80 pixels across instead of 40. With the fix it verifies 50% and 10% zoom, intermediate opening and closing frames, desktop restoration, a rotated output at scale 1.25, and close snapshots.
The reporter manually tested the patched build in a nested Wayland session with their
neon-bleedborder and inner overlay atoverview.zoom = 0.1, and confirmed that it works correctly. Native-session visual review has not been performed.Documentation and the effects example describe the overview scaling behavior. No configuration keys or defaults changed.
Checklist
SCOPE.md, or its scope was agreed in an issue or on Discord first.CONTRIBUTING.md.just format, or this PR has no C++ changes.docs/andexamples/config.toml, or this PR does not change user-facing configuration or behavior.