Repository navigation
Conversation
With 32px rows the orb fills its circle, so the dot's old spot six pixels in from the corner landed on the orb's face.
Contributor
Author
|
Folding this into #23, which adds the other status dots. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #30, sidebar rows use a 32px avatar slot and the orb grows to fill its circle. The unread dot kept its old place, six pixels in from the top-right corner, so it now sits on the orb's face.
This moves the dot to the corner of the avatar slot, onto the rim of the circle, makes it 8px instead of 6px, and gives it a 2px ring in the sidebar colour so it reads as a badge.
Names and previews in the screenshot are demo text.
Testing:
bun run checkandbun run lintpass; checked in the web app in dark mode.