Repository navigation
Let owners turn a bot's own skills on and off - #22
Merged
Merged
Conversation
Owner
|
Maybe we should also use toggles on the Shared tab, to keep the design uniform @migsilva89 |
Collaborator
Author
|
Done, the Shared tab now uses switches too, like Bot skills. I also merged main to resolve the conflicts with #15. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📸 Screenshots & videos
Synthetic test data. iOS screenshots are from the iOS 27 simulator, not a real device.
Web
$list without itiOS
🎫 Issue
Closes #17
🤔 Why
Skills in a bot's own folder always loaded and were not listed, so the only way to turn one off was to delete its file.
📋 What changed
/bots/$botId/skills/local.1 of 1 shared · 2 of 3 bot.disabledSkills, and a newskills.localRPC lists a bot's own skills, including those turned off.$list and expansion, so calling it returns not found.api.mddescribes the new behaviour.Skill files are never changed, and new skills in the bot's folder start on. Left out on purpose: iOS tabs use local state rather than a route, so one Save covers both tabs.
💣 Blast radius
Review: 🔴 Human review
Affected paths: bot storage and migrations, RPC contracts, skill loading and the bot prompt, web and iOS bot settings.
0005_bot_disabled_skills.disabledSkillsto the bot schema and a newskills.localRPC. Clients need a daemon with this change for the Bot skills tab.bot.service.tsandrooms.json.🔍 Verification
Web, on an isolated daemon with synthetic skills and a mock model:
$list and from the prompt sent to the model.$list and the prompt.iOS 27 simulator, iPhone Air, isolated daemon:
skills.discover(which feeds the$list) no longer returns that skill.1 of 1 shared · 2 of 3 bot.Not verified:
$list opened on iOS (checked through the RPC only).✅ Before review
bun run check,bun run lint,bun run lint:deadandbun run test(checkandlintpass;lint:deadfails with the same findings asmain;testpasses but is empty)DESIGN.md, copy in i18n, new functionality on both web and iOSorbs-reviewrun in full, findings fixed