Skip to content

Let owners turn a bot's own skills on and off - #22

Merged
nikuscs merged 3 commits into
nikuscs:mainfrom
migsilva89:feat/bot-skills-toggle
Nov 6, 2026
Merged

nikuscs merged 3 commits into
nikuscs:mainfrom
migsilva89:feat/bot-skills-toggle

Conversation

@migsilva89

Copy link
Copy Markdown
Collaborator

📸 Screenshots & videos

Synthetic test data. iOS screenshots are from the iOS 27 simulator, not a real device.

Web

Shared tab Bot skills, one turned off $ list without it

iOS

Bot skills tab Still off after reopening Skills row summary

🎫 Issue

Closes #17

🤔 Why

Skills in a bot's own folder always loaded and were not listed, so the only way to turn one off was to delete its file.

📋 What changed

  • Web: the Skills section has two tabs, Shared (as before) and Bot skills, with a switch per skill. Bot skills has its own path, /bots/$botId/skills/local.
  • iOS: the same two tabs and switches on the Skills screen, saved together by one Save button. The Skills row in Edit bot summarises both sources, for example 1 of 1 shared · 2 of 3 bot.
  • Daemon: bots store disabledSkills, and a new skills.local RPC lists a bot's own skills, including those turned off.
  • Runtime: a skill that is off is left out of the prompt, the $ list and expansion, so calling it returns not found.
  • Docs: api.md describes the new behaviour.

Skill files are never changed, and new skills in the bot's folder start on. Left out on purpose: iOS tabs use local state rather than a route, so one Save covers both tabs.

💣 Blast radius

Review: 🔴 Human review
Affected paths: bot storage and migrations, RPC contracts, skill loading and the bot prompt, web and iOS bot settings.

⚠️ Before merging

  • Adds migration 0005_bot_disabled_skills.
  • Adds disabledSkills to the bot schema and a new skills.local RPC. Clients need a daemon with this change for the Bot skills tab.
  • No new dependencies and no iOS dev app rebuild.
  • May need a small rebase against open PR Add per-bot MCP servers, bot notes, start turns and durable routines #15, which also touches bot.service.ts and rooms.json.

🔍 Verification

Web, on an isolated daemon with synthetic skills and a mock model:

  • Pass: both tabs work, and the chosen tab survives a reload.
  • Pass: a skill that is off stays listed, and is gone from the $ list and from the prompt sent to the model.
  • Pass: submitting a skill that is off returns 404.
  • Pass: a new skill in the bot's folder starts on, after the catalog cache expires (up to 30 seconds).
  • Pass: turning a skill back on restores it in the $ list and the prompt.
  • Pass: migration from a 0004 database, with existing bots reading as nothing disabled.
  • Pass: skill files unchanged on disk.

iOS 27 simulator, iPhone Air, isolated daemon:

  • Pass: Shared and Bot skills tabs; turning a bot skill off and saving stores it, and it is still off after relaunching the app.
  • Pass: after saving, skills.discover (which feeds the $ list) no longer returns that skill.
  • Pass: the Skills row shows 1 of 1 shared · 2 of 3 bot.

Not verified:

  • A real device, and the $ list opened on iOS (checked through the RPC only).
  • A subagent already running when a skill is turned off.
  • A shared skill with the same name as a bot skill that is off.

✅ Before review

  • bun run check, bun run lint, bun run lint:dead and bun run test (check and lint pass; lint:dead fails with the same findings as main; test passes but is empty)
  • Tested on every affected platform (web, and iOS on the simulator)
  • UI change: follows DESIGN.md, copy in i18n, new functionality on both web and iOS
  • Substantial change: orbs-review run in full, findings fixed

@migsilva89
migsilva89 requested a review from nikuscs as a code owner November 6, 2026 18:39
@nikuscs

nikuscs commented Nov 6, 2026

Copy link
Copy Markdown
Owner

Maybe we should also use toggles on the Shared tab, to keep the design uniform @migsilva89

@migsilva89

Copy link
Copy Markdown
Collaborator Author

Done, the Shared tab now uses switches too, like Bot skills. I also merged main to resolve the conflicts with #15.

@nikuscs
nikuscs merged commit bfa5ade into nikuscs:main Nov 6, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Let me turn a bot's own skills on and off

2 participants