Repository navigation
Show a bot's name in a tooltip in the collapsed sidebar - #21
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Issue
Closes #18
🤔 Why
With the sidebar collapsed, each bot shows only its avatar, so with several bots there is no way to tell them apart without clicking.
📋 What changed
💣 Blast radius
Review: 🔴 Human review: client UI.
Affected paths: the bot rows in the web sidebar (
RoomItem).None.
🔍 Verification
bun run check,bun run lint,bun run lint:dead(only the existing exported service type warnings) andbun run test: pass.tooltipprop, which is hidden unless the sidebar is collapsed and not on mobile.✅ Before review
bun run check,bun run lint,bun run lint:deadandbun run testDESIGN.md, copy in i18n,new functionality on both web and iOS(iOS has no collapsed sidebar)orbs-reviewrun in full, findings fixed