Skip to content

Add a fullscreen button to iOS videos and group routines into upcoming and past - #16

Merged
nikuscs merged 2 commits into
nikuscs:mainfrom
migsilva89:fix/video-fullscreen-and-routine-groups
Nov 6, 2026
Merged

nikuscs merged 2 commits into
nikuscs:mainfrom
migsilva89:fix/video-fullscreen-and-routine-groups

Conversation

@migsilva89

@migsilva89 migsilva89 commented Nov 6, 2026 •

Copy link
Copy Markdown
Collaborator

📸 Screenshots & videos

Synthetic test data. iOS screenshots are from the iOS 27 simulator, not a real device.

Video fullscreen (iOS)

Fullscreen button after Play Native fullscreen

Routines (iOS): one line per row; long press shows details; tapping the warning icon explains the failure.

Light Long press, long name Failed icon tapped Dark Long press, failed run

Routines (web): hovering a row shows the full name, schedule and last run.

Dark Hover, long name Failed icon
Light Hover, failed run

🎫 Issue

Closes #11
Closes #12

🤔 Why

AVKit collapses its fullscreen button to 0×0 at the chat player's 256pt width (measured at 256 and 300pt; visible at 340pt), so iOS videos could not go fullscreen. Routine lists mixed finished one-offs with upcoming ones, buried failures and cut off long names.

📋 What changed

  • iOS: the chat video shows its own fullscreen button once playback starts; the routine list refreshes every minute, like web.
  • Web and iOS: routines are grouped into Upcoming, by next run, and Past, failed runs first then most recent.
  • Web and iOS: each routine row is one line with the name, the switch and a vertical-dots menu. Hover (web) or long press (iOS) shows the full name, schedule and last run. A failed last run shows as a warning icon next to the name; hover (web) or tap (iOS) explains it.
  • Left out on purpose: no server change. A routine with a next run stays in Upcoming even if its last run failed; a paused routine goes to Past only if it has run.

💣 Blast radius

Review: 🔴 Human review: client UI.
Affected paths: the iOS chat video player, and the routine lists on web and iOS.

⚠️ Before merging

None. No new dependency, so no iOS dev app rebuild.

🔍 Verification

  • bun run check, bun run lint: pass.
  • bun run test: passes, but only the i18n compile task ran.
  • bun run lint:dead: fails only on files this PR does not change.
  • Web, isolated daemon: a real one-off routine fired, failed and appeared under Past after a reload; tooltip checked in the right panel, in light and dark themes, and at a narrow width.
  • Grouping order: checked with a throwaway script against the real helper.
  • iOS 27 simulator, standalone AVKit probe: fullscreen button is 0×0 at 256pt, and fullscreen opens programmatically from a 256pt player.
  • iOS 27 simulator, iPhone Air, video: only Play shows before playback; after Play the fullscreen button appears top-left; tapping it opens native fullscreen with AVKit controls (close, play/pause, ±10s, scrubber).
  • iOS 27 simulator, iPhone Air, routines (light and dark): Upcoming and Past groups; one-line rows with switch and menu centred; long press shows full name, schedule and last run; tapping the warning icon shows "Last run failed".
  • Web, isolated daemon (light and dark): hover details for a long name, a failed run and a paused routine; failed icon popover; keyboard focus and Escape.
  • Not verified: exiting fullscreen with the close button; a real device; closing the web popover by touch; a routine changing group without a reload.

✅ Before review

  • bun run check, bun run lint, bun run lint:dead and bun run test
  • Tested on every affected platform
  • UI change: follows DESIGN.md, copy in i18n, new functionality on both web and iOS
  • Substantial change: orbs-review run in full, findings fixed

@migsilva89
migsilva89 marked this pull request as ready for review November 6, 2026 10:43
@migsilva89
migsilva89 requested a review from nikuscs as a code owner November 6, 2026 10:43
@nikuscs

nikuscs commented Nov 6, 2026

Copy link
Copy Markdown
Owner

Nice one, the grouping reads much better. A few UI things before merging, these lists need to look perfect:

  1. Keep routine rows minimal. One line per row: the name, the switch and the menu. Drop the second line (schedule) and the "Last run failed" text from the row.
  2. More info on demand. On web, hovering the row shows the full name, the schedule and the last run status in a popover/tooltip. On iOS, a long press on the row shows the same.
  3. Failed runs as an icon. Replace the "Last run failed" text with a small warning icon next to the name. Hover (web) or tap (iOS) opens a popover explaining the last run failed. Same on both platforms.
  4. Alignment on iOS. The switch sits at the top of the row while the … button is vertically centered (very visible in the 3rd screenshot on the two-line and failed rows). Both should be centered on the row.
  5. Vertical dots. The row menu on iOS uses horizontal … (Ellipsis). Use vertical dots (EllipsisVertical) to match the rest of the app, like the web routine rows.

Please post fresh screenshots on web and iOS (light and dark) with a long name, a failed run and a paused routine once it's updated.

@nikuscs
nikuscs merged commit d941a0e into nikuscs:main Nov 6, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sort routines into upcoming and past, and show full names Video has no fullscreen button in the iOS app

2 participants