Repository navigation
Add a fullscreen button to iOS videos and group routines into upcoming and past - #16
Merged
nikuscs merged 2 commits intoNov 6, 2026
Conversation
migsilva89
marked this pull request as ready for review
November 6, 2026 10:43
Owner
|
Nice one, the grouping reads much better. A few UI things before merging, these lists need to look perfect:
Please post fresh screenshots on web and iOS (light and dark) with a long name, a failed run and a paused routine once it's updated. |
nikuscs
approved these changes
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📸 Screenshots & videos
Synthetic test data. iOS screenshots are from the iOS 27 simulator, not a real device.
Video fullscreen (iOS)
Routines (iOS): one line per row; long press shows details; tapping the warning icon explains the failure.
Routines (web): hovering a row shows the full name, schedule and last run.
🎫 Issue
Closes #11
Closes #12
🤔 Why
AVKit collapses its fullscreen button to 0×0 at the chat player's 256pt width (measured at 256 and 300pt; visible at 340pt), so iOS videos could not go fullscreen. Routine lists mixed finished one-offs with upcoming ones, buried failures and cut off long names.
📋 What changed
💣 Blast radius
Review: 🔴 Human review: client UI.
Affected paths: the iOS chat video player, and the routine lists on web and iOS.
None. No new dependency, so no iOS dev app rebuild.
🔍 Verification
bun run check,bun run lint: pass.bun run test: passes, but only the i18n compile task ran.bun run lint:dead: fails only on files this PR does not change.✅ Before review
bun run check,bun run lint,bun run lint:deadandbun run testDESIGN.md, copy in i18n, new functionality on both web and iOSorbs-reviewrun in full, findings fixed