Repository navigation
Deliver verified standalone editor support (#1390) - #1982
Merged
Merged
Conversation
added 13 commits
October 6, 2026 21:22
Contributor
|
Important Review skippedToo many files! This PR contains 243 files, which is 143 over the limit of 100. To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry. ⚙️ Run configuration
⛔ Files ignored due to path filters (2)
📒 Files selected for processing (243)
You can disable this status message by setting the
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SharpTS's full language-server mode lacked ordinary editing features and reused mutable or insufficiently validated analysis. This implements epic #1390 as a bounded standalone workflow: immutable checked snapshots, source-class definitions/references, semantic hover, lexical/member completion, call/constructor signatures, and versioned single-file ECMAScript-private rename. Existing lexical behavior and interop precedence remain intact.
Standalone clients explicitly use
full --diagnostics all. The shipping VS Code extension keepsinterop-only --diagnostics sharpts-only; feature mode remains initialization-bound while diagnostics can change live. One pinned external Prettier owns formatting. Unknown/stale/recovered facts cannot authorize edits; structural/public/TypeScript-private member rename, nested private domains, inlay hints, semantic tokens and folding remain outside this delivery.Validation:
Measured limits: equivalent existing multi-project warm requests improved 86–87% with zero checks; cold latency increased 26–37% and cold allocations 15%. Repeated large custom CLR-reference validation remains expensive. The reports retain these regressions and their investigation. The eight-entry/64 MiB cache budget estimates completed graphs, not total process memory. Timings do not gate CI.
See release notes, editor contract, local verification index, and workflow measurements. The final-head CI matrix and GUI packaging/native checks passed, including both editor-contract hosts. A runner-only follow-up resolves the first pinned Node application when multiple PATH matches exist; the exact version check remains enforced. A final documentation-only follow-up links actual-client evidence to committed compact reports; both workflows also passed on that exact head. Each child implementation was verified and committed separately; the superseded inlay/token/folding tickets were closed as not planned with rationale retained.
Closes #1390
Closes #1391
Closes #1392
Closes #1393
Closes #1394
Closes #1398
Closes #1975
Closes #1976
Closes #1977
Closes #1978
Closes #1979
Closes #1980
Closes #1981