Repository navigation
Make StringExtractor.extractStrings linear - #25
Merged
Merged
Conversation
Runs were built a Character at a time with String.count (linear) checked before every byte. Gather bytes and build each string once; results are unchanged (equivalence test against the old implementation on random data, including CR LF pairs and minLength 0). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
extractStringsappended aCharacterat a time and checkedcurrent.count(linear in the run) before every byte, so long printable runs cost up tomaxLength× their length. It now gathers bytes and builds each string once.Results are unchanged: a new test compares against the previous implementation on 200 random inputs (text, whitespace, CR LF pairs, Latin-1) at four length settings, including
minLength: 0. The existing StringExtractor tests moved toAlgorithms/Text/StringExtractorTests.swift.Found profiling disk image imports, where string scans of whole disks dominated.
Tests: 391 + 32, 0 failures.
🤖 Generated with Claude Code