Repository navigation
Add DataReader, BinaryDataReader and StringExtractor - #23
Merged
Merged
Conversation
relocate-binary-readers-into-dak (DesignAlgorithmsKit-Specs), for FileSystemCore relocate-retro-and-app-specific-code 1.6. Generic byte-level helpers move down from FileSystemCore, hardened on the way: byte-wise reads (no misaligned loads), negative offsets never trap, Data slices read relative to their start, and a throwing generic read/write so a missing field differs from 0. DataReader throws BinaryReadError instead of FileSystemError. StringExtractor carries only the generic printable-run scan; vendor heuristics stay in FileSystemCore. The byte-order enum is ByteOrder (RetroCore already has a public Endianness). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relocate-binary-readers-into-dak (DesignAlgorithmsKit-Specs), for
FileSystemCore relocate-retro-and-app-specific-code 1.6. Generic byte-level
helpers move down from FileSystemCore, hardened on the way: byte-wise reads
(no misaligned loads), negative offsets never trap, Data slices read
relative to their start, and a throwing generic read/write so a missing
field differs from 0. DataReader throws BinaryReadError instead of
FileSystemError. StringExtractor carries only the generic printable-run
scan; vendor heuristics stay in FileSystemCore. The byte-order enum is
ByteOrder (RetroCore already has a public Endianness).
Tests:
swift testruns 386 unit tests and 2 integration tests, all passing (12 new).swift buildandxcodebuild docbuildhave no warnings.🤖 Generated with Claude Code