Repository navigation
Make ULID text follow the ULID specification - #21
Merged
Merged
Conversation
fix-ulid-spec-compliance (DesignAlgorithmsKit-Specs). Encoding puts the 2 padding bits at the front (first character 0-7) instead of the end, and parsing matches; strings starting above 7 are rejected. ULID(legacyString:) reads text from 1.10.x/1.11.x so stored IDs can be migrated; bytes are unchanged. Spec vectors: 01ARZ3NDEKTSV4RRFFQ69G5FAV round-trips and timestamp 1469922850259 encodes as 01ARZ3NDEK... Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix-ulid-spec-compliance (DesignAlgorithmsKit-Specs). Encoding puts the 2
padding bits at the front (first character 0-7) instead of the end, and
parsing matches; strings starting above 7 are rejected. ULID(legacyString:)
reads text from 1.10.x/1.11.x so stored IDs can be migrated; bytes are
unchanged. Spec vectors: 01ARZ3NDEKTSV4RRFFQ69G5FAV round-trips and
timestamp 1469922850259 encodes as 01ARZ3NDEK...
Breaking text format: needs a minor release with the CHANGELOG migration note (planned for the next DAK release).
Tests:
swift testpasses 369 tests, including the spec vectors and the legacy migration vector05B3WENNTFB7CK31XYWS60NXBC→01ARZ3NDEKTSV4RRFFQ69G5FAV.🤖 Generated with Claude Code