Repository navigation
Fix job cancellation, orchestrator errors, queue race, lock release - #20
Merged
Merged
Conversation
fix-async-work-correctness (DesignAlgorithmsKit-Specs). - JobManager.cancel removes the pending job so it never runs - TaskOrchestrator wraps task errors in OrchestrationError.taskFailure - ProcessingQueue marks items .processing synchronously before spawning, bounding concurrency and starting each item once; drops finished handles - ResourceCoordinator releases locks before access returns, evicts idle per-key locks, adds withWriteLock(for:operation:) Two queue tests relied on add/retry leaving items pending until a later task ran; they now pause the queue first. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix-async-work-correctness (DesignAlgorithmsKit-Specs).
bounding concurrency and starting each item once; drops finished handles
per-key locks, adds withWriteLock(for:operation:)
Two queue tests relied on add/retry leaving items pending until a later
task ran; they now pause the queue first.
Tests:
swift testpasses 362 tests, three runs in a row. On the old code the new JobManager and TaskOrchestrator tests fail (the cancelled job ends.completed; the rawBoomerror escapes). The queue and lock tests use the new API.🤖 Generated with Claude Code