Repository navigation
Fix Merkle proofs for unpaired nodes, Bloom sizing, GZIP trailer - #19
Merged
Merged
Conversation
fix-algorithm-edge-cases (DesignAlgorithmsKit-Specs). - generateProof adds the node's own hash as sibling for an unpaired node, so proofs verify for every leaf of odd trees (roots unchanged) - Bloom filters clamp capacity (>= 1) and rate (open interval 0..1) instead of trapping; Int.bloomHash uses the bit pattern for negative values - Gzip.decompress checks the CRC-32 and ISIZE trailer and reads XLEN little-endian; accepts Data slices Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix-algorithm-edge-cases (DesignAlgorithmsKit-Specs).
so proofs verify for every leaf of odd trees (roots unchanged)
of trapping; Int.bloomHash uses the bit pattern for negative values
little-endian; accepts Data slices
Tests:
swift testpasses 355 tests (343 before + 12 new). Against the old sources the new tests fail: Merkle proofs for blocks 2/3, 4/5, 4/6, 5/6 and 6/7; GZIP corrupt CRC and ISIZE; the negativeInttraps.🤖 Generated with Claude Code